Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM-715] Mark overridable extension methods as @objc #3

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

mpospese
Copy link
Contributor

@mpospese mpospese commented Jun 9, 2022

Introduction

Compiling our framework in Xcode 14 revealed two new compiler warnings.

/Users/mpospese/Source/YML/Aether/Y-Core-UI/Sources/YCoreUI/Extensions/UIKit/UIScrollView+keyboardNotifications.swift:53:5: warning build: Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

/Users/mpospese/Source/YML/Aether/Y-Core-UI/Sources/YCoreUI/Extensions/UIKit/UIScrollView+keyboardNotifications.swift:72:5: warning build: Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

Purpose

Fix the problem that was triggering the compiler warning.

Scope

Minor change to UIScrollView extension for keyboard avoidance

Discussion

The compiler recommendation was to change open to public but because these two methods are intended to be overridden, I added @objc decorator instead (which allows them to be correctly overridden).

@mpospese mpospese merged commit 573dbdf into main Jun 13, 2022
@mpospese mpospese deleted the bugfix/CM-715-xcode14-warnings branch June 13, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants