Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pyston support #70

Closed
kura opened this issue Jul 5, 2021 · 2 comments · Fixed by #71
Closed

Add Pyston support #70

kura opened this issue Jul 5, 2021 · 2 comments · Fixed by #71

Comments

@kura
Copy link

kura commented Jul 5, 2021

Pyston is part of the python action but it is still installable. It'd be great if you could add a way to detect Pyston and use that.

I tried using using TOXENV to make my tests run using Pyston but it kept creating a Python 3.8 virtual environment rather than using my Pyston environment

      - name: Set up Pyston
        if: ${{ matrix.python-version == 'pyston' }}
        env:
          TOXENV: pyston,pyston-setproctitle,pyston-uvloop
        run: |
          git clone https://github.com/pyenv/pyenv.git ~/.pyenv
          ~/.pyenv/bin/pyenv install pyston-2.2
          ~/.pyenv/bin/pyenv local pyston-2.2
      - name: unittest
        run: tox -vv

This was the tox verbose output

tox-gh-actions config: {'python': {'3.7': ['py37', 'py37-setproctitle', 'py37-uvloop'], '3.8': ['py38', 'py38-setproctitle', 'py38-uvloop'], '3.9': ['py39', 'py39-setproctitle', 'py39-uvloop'], 'pypy-3.7': ['pypy3', 'pypy3-setproctitle', 'pypy3-uvloop'], 'pyston': ['pyston', 'pyston-setproctitle', 'pyston-uvloop']}, 'env': {}}

I had to resort to adding an if statement and calling tox -e env,list to make it work. I suspect this is due to the scoping of env and it only applying to the current step.

@kura kura changed the title Add Pyston support Add Pyston support / TOXENV variable not working 2.5.0 Jul 5, 2021
@kura kura changed the title Add Pyston support / TOXENV variable not working 2.5.0 Add Pyston support / TOXENV variable not working in 2.5.0 Jul 5, 2021
@kura kura changed the title Add Pyston support / TOXENV variable not working in 2.5.0 Add Pyston support Jul 5, 2021
@ymyzk ymyzk closed this as completed in #71 Jul 13, 2021
@ymyzk
Copy link
Owner

ymyzk commented Jul 13, 2021

Thanks for proposing an idea. This is implemented in #71.

@kura
Copy link
Author

kura commented Jul 13, 2021

Awesome, I will give it a try tonight. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants