Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize the code, fix some problems #21

Merged
merged 1 commit into from Dec 10, 2022
Merged

optimize the code, fix some problems #21

merged 1 commit into from Dec 10, 2022

Conversation

hsiong
Copy link
Member

@hsiong hsiong commented Dec 8, 2022

@hsiong
+ resolved #15
793ec33 
+ resolved #16
+ resolved #19
+ resolved #20
@chuzilaolin
Copy link

You're awesome

@szy0syz
Copy link

szy0syz commented Dec 9, 2022 •
edited

LGTM
@LG-Brother

chuzilaolin
chuzilaolin reviewed Dec 9, 2022
View reviewed changes
Copy link

@chuzilaolin chuzilaolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@hsiong hsiong requested review from chuzilaolin and removed request for szy0syz December 9, 2022 04:41
chuzilaolin
chuzilaolin approved these changes Dec 9, 2022
View reviewed changes
Copy link

@chuzilaolin chuzilaolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@hsiong hsiong merged commit 5747c51 into main Dec 10, 2022
@hsiong hsiong deleted the hsiong branch December 10, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuzilaolin chuzilaolin chuzilaolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hsiong @chuzilaolin @szy0syz