Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing subsets hints in creator #1503

Merged
merged 1 commit into from May 12, 2021
Merged

Existing subsets hints in creator #1503

merged 1 commit into from May 12, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 11, 2021 •
edited

Issue

Subset hints in Creator tool dropdown do not find out other possible user inputs if user intup has different letter case than concatenated subset name. That is because user input is replaced in concatenated subset name to get possible regex to find other possible user inputs.

user_input = "anim"
subset_name = "renderCompositingAnim"
expected_regex = "renderCompositing(.+)"
real_regex = "renderCompositingAnim"

Changes

  • replacement of user input in concatenated subset name is not case sensitive
Related Prs
avalon-core ynput/avalon-core#334
Pype 2 PRs
pype #1502
avalon-core ynput/avalon-core#333

This was referenced May 11, 2021
Merged
Merged
Merged
@iLLiCiTiT iLLiCiTiT self-assigned this May 11, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 11, 2021 15:50
@iLLiCiTiT iLLiCiTiT added backend type: bug Something isn't working labels May 11, 2021
mkolar
mkolar approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok in 3.0, @64qam could you please check 2.x branch on site?

@mkolar mkolar merged commit fd482d3 into develop May 12, 2021
@mkolar mkolar deleted the bugfix/3.0_existing_subsets_hints branch May 12, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @mkolar