Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a published workfile from the "workfiles" interface #2442

Conversation

ClementHector
Copy link
Contributor

This feature follow up on discussion #2372

This add a checkbox button to the workfiles interface to ask interface to show the published workfiles and open them:

image

The interface use the workfile Family publishing profile to find the published filepath.

Note

When "published" is checked, the "browse" and "save as" buttons are deactivated since we only want the users to be allowed to open a published workfile

image

@iLLiCiTiT
Copy link
Member

This feature follow up on discussion #2372

Discussion leads to Two step validation.

The interface use the workfile Family publishing profile to find the published filepath.

I think that published workfile is "backup of source" of published subsets so it should not be allowed to open and modify.
Also I'm not sure if workfiles logic should contain logic related to published stuff. Publish logic is much more complex and published workfile in theory may not be related to any task...

The only way that make sense to me is to "load" the workfile -> Make a loader which will make a copy of published workfile to workdirectory.

@mkolar
Copy link
Member

mkolar commented Jan 4, 2022

I'd say this is way too dangerous and invites editing of the published workfiles, however, the effect can be achieved in a safer way I believe.

  • if user chooses to open published workfile, switch the list view of the workfiles to the published ones.
  • When user chooses a workfile and hits open, the file should be copied to the workarea and opened from there
  • during the copying the workfiles should be renamed with a suffix _published or something similar added to easily identify where it originated from.

This poses a few question of what context do we load the workfile into? My suggestion would be to load it into currently active one, rather than the one selected in the workfiels app. That would allow for instance latest layout to be loaded easily as a starting point for animation scenes.

@mkolar mkolar self-requested a review January 4, 2022 15:10
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous comment. I believe we should make this a bit safer by copying the file into current working context.

@ClementHector ClementHector force-pushed the feature/open_published_workfiles_from_workfiles_interface branch from f87819e to b6bd7da Compare February 2, 2022 11:08
@mkolar
Copy link
Member

mkolar commented Mar 18, 2022

We will clean this up on our end based on the discussion so it can be merged and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants