Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

Merged
merged 24 commits into from
Jul 4, 2022
Merged

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

merged 24 commits into from
Jul 4, 2022

Commits on Jun 17, 2022

  1. Test resolution values against settings

    Allan Ihsan committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d4df16b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into OP-3088_Ability-to-sync-asset-resolution-… 

    …playblast-and-review-resolution
    Allan Ihsan committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    f4d6d1e View commit details
    Browse the repository at this point in the history

  3. Update openpype/hosts/maya/plugins/publish/extract_playblast.py 

    Simplify settings capture statement.

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
    @iLLiCiTiT
    Allan I. A and iLLiCiTiT committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    0dfe3b6 View commit details
    Browse the repository at this point in the history

  4. Add resolution overrides to creator.

    Allan Ihsan committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d1b0c37 View commit details
    Browse the repository at this point in the history

  5. Add resolution overrides to collector.

    Allan Ihsan committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    eb3afe6 View commit details
    Browse the repository at this point in the history

  6. Correct resolution overrides in extractor

    Allan Ihsan committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    491e356 View commit details
    Browse the repository at this point in the history

  7. Add comments

    Allan Ihsan committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    594707f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Fix comparison statements.

    Allan Ihsan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0c1688e View commit details
    Browse the repository at this point in the history

  2. Fix comments.

    Allan Ihsan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    c6d473f View commit details
    Browse the repository at this point in the history

  3. Change logic into correct setting.

    Allan Ihsan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    3968e16 View commit details
    Browse the repository at this point in the history

  4. Revert "Change logic into correct setting." 

    This reverts commit 3968e16.
    Allan Ihsan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9778d27 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Merge branch 'develop' into OP-3088_Ability-to-sync-asset-resolution-… 

    …playblast-and-review-resolution
    Allan Ihsan committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    384a44c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Make appropriate feature fixes.

    Allan Ihsan committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    46bfbd2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Rename attr into instance refactor.

    Allan Ihsan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    409bf1b View commit details
    Browse the repository at this point in the history

  2. Fix thumbnail extractor to match playblast resolution.

    Allan Ihsan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    aca0c2a View commit details
    Browse the repository at this point in the history

  3. Adjust dimensions to grab correct values from asset. 

    Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
    @iLLiCiTiT
    Allan I. A and iLLiCiTiT committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    e9edb1c View commit details
    Browse the repository at this point in the history

  4. Simplify testing of cases for resolution 

    Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
    @iLLiCiTiT
    Allan I. A and iLLiCiTiT committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    be2f9a0 View commit details
    Browse the repository at this point in the history

  5. Variable rename.

    Allan Ihsan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c67308d View commit details
    Browse the repository at this point in the history

  6. Simplify logic in thumbnail extractor.

    Allan Ihsan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    bc18f8f View commit details
    Browse the repository at this point in the history

  7. Change naming in interface.

    Allan Ihsan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4514ed8 View commit details
    Browse the repository at this point in the history

  8. Fix instance variable name.

    Allan Ihsan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    92bf597 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Fix asset data key.

    Allan Ihsan committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    9bfff7a View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. Alter final logic and change attribute naming to more pythonic conven… 

    …tion.
    Allan Ihsan committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    ad9b01c View commit details
    Browse the repository at this point in the history

  2. Style fix.

    Allan Ihsan committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    8307ea8 View commit details
    Browse the repository at this point in the history