Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor bugfixes #4172

Merged
merged 5 commits into from
Dec 9, 2022
+9 −15
Merged

Various minor bugfixes #4172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7772ac7
Added missing parenthesis
2-REC Dec 5, 2022
f9680cc
Removed extra quotes
2-REC Dec 5, 2022
605432c
Removed duplicate command
2-REC Dec 5, 2022
ba149de
Check asset is 'not selected'
2-REC Dec 5, 2022
98f88d0
Merge branch 'pypeclub:develop' into bugfix/various-minor-bugfixes
2-REC Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions openpype/modules/ftrack/event_handlers_server/event_first_version_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ def launch(self, session, event):

new_status = asset_version_statuses.get(found_item["status"])
if not new_status:
self.log.warning(
self.log.warning((
"AssetVersion doesn't have status `{}`."
).format(found_item["status"])
).format(found_item["status"]))
continue

try:
Expand Down
2 changes: 1 addition & 1 deletion openpype/settings/defaults/project_settings/maya.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,7 @@
"current_context": [
{
"subset_name_filters": [
"\".+[Mm]ain\""
".+[Mm]ain"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antirotor Can you confirm this is ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, there shouldn't be any double quotes

],
"families": [
"model"
Expand Down
18 changes: 6 additions & 12 deletions openpype/tools/standalonepublish/widgets/widget_family.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,19 +186,11 @@ def _on_data_changed(self):
if item is None:
return

asset_doc = None
if asset_name != self.NOT_SELECTED:
# Get the assets from the database which match with the name
project_name = self.dbcon.active_project()
asset_doc = get_asset_by_name(
project_name, asset_name, fields=["_id"]
)

# Get plugin and family
plugin = item.data(PluginRole)

# Early exit if no asset name
if not asset_name.strip():
if (
asset_name == self.NOT_SELECTED
or not asset_name.strip()
):
self._build_menu([])
item.setData(ExistsRole, False)
print("Asset name is required ..")
Expand All @@ -210,8 +202,10 @@ def _on_data_changed(self):
asset_doc = get_asset_by_name(
project_name, asset_name, fields=["_id"]
)

# Get plugin
plugin = item.data(PluginRole)

if asset_doc and plugin:
asset_id = asset_doc["_id"]
task_name = self.dbcon.Session["AVALON_TASK"]
Expand Down