Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreal: Publishing and Loading for UAssets #4198

Merged
merged 11 commits into from Jan 9, 2023

Conversation

simonebarbieri
Copy link
Member

Brief description

Implementation for the publishing and loading for UAssets in Unreal.

Description

This PR implements the publishing and loading of UAssets in Unreal. At this moment, only a single UAssets can be published. Hence, it has been included a validator to check that the UAssets doesn't have any dependency before being published.

@simonebarbieri simonebarbieri added host: UE type: feature Larger, user affecting changes and completely new things labels Dec 8, 2022
@simonebarbieri simonebarbieri self-assigned this Dec 8, 2022
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure if this will work as base for UAsset publishing yet - as we've discussed, it should be simple, checking for dependencies in validator, but look at what happened to me :)

What I did was that I've just imported simple mesh from .obj - it correctly imported as StaticMesh. I can select it, create UAsset publishing instance and it will fail during the publishing on Check no dependencies with following:

Dependencies found: ['/Script/InterchangeCore', '/Script/InterchangeEngine', '/Script/NavigationSystem', '/Engine/EngineMaterials/WorldGridMaterial', '/Script/InterchangePipelines', '/Script/InterchangeFactoryNodes']

Question is how to deal with this - all of these are probably built-in asset. So they should be available on the project we are trying to load uaset in, right? So maybe we should allow these - and with it, what is the criteria for accepting dependencies and rejecting.

Can we say that descendants of /Engine/* path are all OK (because they are built in)? With /Script/ it is complicated, but maybe we can say that only direct descendant of /Script are OK, but all others are not (like /Script/Foo is OK, but /Script/Bar/Alice is not)?

@antirotor
Copy link
Member

So, I have this simple obj imported, I've created uasset (strangely, the mesh asset didn't moved to the instance folder, I had to do it manually). From that point everything seems fine, except publish can't find the instance of UAsset:

image

Note
Tested in Unreal 5.1

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works! thanks

@antirotor antirotor merged commit 0e168a5 into develop Jan 9, 2023
@antirotor antirotor deleted the feature/unreal-uasset_management branch January 9, 2023 17:38
@github-actions github-actions bot added this to the next-patch milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: UE type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants