Deadline: fix dependencies #4242
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
added
type: bug
|
Task linked: OP-4556 Maya: Deadline job dependencies |
|
Seem that dependencies works ok
but there is some issue with tile assembly job "Empty file name is not legal" parameter
@antirotor So not sure if change needed or this PR is ok with its portion functional and these issues not connected to it. |
Yep, there is still bug for tile assembly but that is not connected to dependencies and deservers another PR |
LiborBatek
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This is fixing how job and asset dependencies were added to the jobs. First issue was that scene was added as asset dependency twice, but as original scene and published too. Second issue was that job dependencies for tile assembler job were added under wrong key and therefor they were not taken into consideration.
Testing
Submit job from Maya having tiles. Tile assembly jobs should have proper Job dependency - pointing to render job. All jobs should have proper asset dependency - only one scene.
Resolves #4164