Scene Manager: Fix variable name #4268
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-4666 Scene Manager: Update all to latest bug |
|
From user POV seems normal. but will keep decision for ya devs... |
|
@LiborBatek is that the wrong screenshot you uploaded? |
|
@BigRoy well I guess it seems ok to me...I wasnt sure cos its probably more about code review I guess? The dialog works fine no any glitches, To your question, no its not that wrong one (with issue) ...I just tested this PR in maya2023 and seems normal. |
antirotor
approved these changes
Jan 4, 2023
antirotor
deleted the
bugfix/OP-4666_Scene-Manager-Update-all-to-latest-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Fix access to width of geometry in
ScrollMessageBox.Description
The
ScrollMessageBoxtried to access width of desktop by accessingwidthattribute but it is a method so comparison failed.Also renamed variable
max_lentomessage_len.Additional info
We should maybe rewrite the whole dialog as the logic of size definition is not readable much. The dialog also contains "Copy to clipboard" button which is on right side next to OK and Cancel which is not very intuitive. Dialog does not have enabled close.
Testing notes:
Resolves #4243 (comment)