Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create: Enhance instance & context changes #4375

Merged
merged 17 commits into from
Feb 8, 2023
Merged

Create: Enhance instance & context changes #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a6df39c
fix 'update_context_data' in tray publisher
iLLiCiTiT Jan 26, 2023
fa62e79
removed unused methods
iLLiCiTiT Jan 26, 2023
1496b74
added helper object to handle changes
iLLiCiTiT Jan 26, 2023
e46042c
use the 'ChangedItem' object to handle changes
iLLiCiTiT Jan 26, 2023
f9f0777
adde items method to extend dictionary approach
iLLiCiTiT Jan 26, 2023
c885795
keep track of new/old keys
iLLiCiTiT Jan 26, 2023
7c1a39d
added 'is_dict' property
iLLiCiTiT Jan 26, 2023
44bcfc1
fix 'items' method
iLLiCiTiT Jan 26, 2023
dbda359
Merge branch 'develop' into feature/better_instance_changes
iLLiCiTiT Feb 2, 2023
0dbb63d
modified change item a little
iLLiCiTiT Feb 2, 2023
6ca987f
modified houdini to use new changes object
iLLiCiTiT Feb 2, 2023
0b65168
fix other places using changes
iLLiCiTiT Feb 2, 2023
638375c
add missing attribute usage
iLLiCiTiT Feb 2, 2023
a9e1399
modified code example to also contain tests
iLLiCiTiT Feb 2, 2023
6120f21
Merge branch 'develop' into feature/better_instance_changes
iLLiCiTiT Feb 7, 2023
9110f70
use safe access to "subset" in AE
iLLiCiTiT Feb 7, 2023
cba888e
small docstring/comments enhancements
iLLiCiTiT Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openpype/hosts/aftereffects/plugins/create/create_render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def update_instances(self, update_list):
subset_change = _changes.get("subset")
if subset_change:
api.get_stub().rename_item(created_inst.data["members"][0],
subset_change[1])
subset_change.new_value)

def remove_instances(self, instances):
for instance in instances:
Expand Down
6 changes: 3 additions & 3 deletions openpype/hosts/houdini/api/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,12 @@ def collect_instances(self):
self._add_instance_to_context(created_instance)

def update_instances(self, update_list):
for created_inst, _changes in update_list:
for created_inst, changes in update_list:
instance_node = hou.node(created_inst.get("instance_node"))

new_values = {
key: new_value
for key, (_old_value, new_value) in _changes.items()
key: changes[key].new_value
for key in changes.changed_keys
}
imprint(
instance_node,
Expand Down
6 changes: 3 additions & 3 deletions openpype/hosts/max/api/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ def collect_instances(self):
self._add_instance_to_context(created_instance)

def update_instances(self, update_list):
for created_inst, _changes in update_list:
for created_inst, changes in update_list:
instance_node = created_inst.get("instance_node")

new_values = {
key: new_value
for key, (_old_value, new_value) in _changes.items()
key: changes[key].new_value
for key in changes.changed_keys
}
imprint(
instance_node,
Expand Down
2 changes: 1 addition & 1 deletion openpype/hosts/traypublisher/api/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def get_context_data(self):
return HostContext.get_context_data()

def update_context_data(self, data, changes):
HostContext.save_context_data(data, changes)
HostContext.save_context_data(data)

def set_project_name(self, project_name):
# TODO Deregister project specific plugins and register new project
Expand Down
Loading