Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Remove 'openpype.api' #4413

Merged
merged 2 commits into from
Feb 9, 2023
Merged

General: Remove 'openpype.api' #4413

merged 2 commits into from
Feb 9, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 1, 2023

Brief description

PR is removing openpype/api.py file which is causing a lot of troubles and cross-imports.

Description

I wanted to remove the file slowly function by function but it always reappear somewhere in codebase even if most of the functionality imported from there is triggering deprecation warnings. This is small change which may have huge impact.

There shouldn't be anything in openpype codebase which is using openpype.api anymore so only possible issues are in customized repositories or custom addons.

Testing notes:

Nothing should crash on imports (easy to test, huh?).

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 1, 2023
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Feb 1, 2023
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smells good to me ;)

@jakubjezek001 jakubjezek001 assigned tokejepsen and unassigned iLLiCiTiT Feb 9, 2023
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.

@kalisp kalisp assigned iLLiCiTiT and unassigned tokejepsen Feb 9, 2023
@iLLiCiTiT iLLiCiTiT merged commit 10112d1 into develop Feb 9, 2023
@github-actions github-actions bot added this to the next-patch milestone Feb 9, 2023
@iLLiCiTiT iLLiCiTiT deleted the chore/remove_api branch February 9, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants