Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DL on MacOS #4418

Merged
merged 7 commits into from
Feb 9, 2023
Merged

Fix: DL on MacOS #4418

merged 7 commits into from
Feb 9, 2023

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Feb 2, 2023

Brief description

This works if DL Openpype plugin Installation Directories is set to level of app bundle (eg. '/Applications/OpenPype 3.15.0.app')

This works if DL Openpype plugin Installation Directories is set to level of app bundle (eg. '/Applications/OpenPype 3.15.0.app')
@kalisp kalisp added the type: bug Something isn't working label Feb 2, 2023
@kalisp kalisp requested a review from antirotor February 2, 2023 12:03
@kalisp kalisp self-assigned this Feb 2, 2023
@ynbot
Copy link
Contributor

ynbot commented Feb 2, 2023

Task linked: OP-4513 Deadline on MacOS

@kalisp
Copy link
Member Author

kalisp commented Feb 2, 2023

Still failing with:

 Click will abort further execution because Python 3 was configured to use ASCII as encoding for the environment. Consult https://click.palletsprojects.com/python3/ for mitigation steps.
2023-02-02 12:50:30:  0: This system lists a couple of UTF-8 supporting locales that you can pick from. The following suitable locales were discovered: af_ZA.UTF-8, am_ET.UTF-8, be_BY.UTF-8, bg_BG.UTF-8, ca_ES.UTF-8, cs_CZ.UTF-8, da_DK.UTF-8, de_AT.UTF-8, de_CH.UTF-8, de_DE.UTF-8, el_GR.UTF-8, en_AU.UTF-8, en_CA.UTF-8, en_GB.UTF-8, en_IE.UTF-8, en_NZ.UTF-8, en_US.UTF-8, es_ES.UTF-8, et_EE.UTF-8, eu_ES.UTF-8, fi_FI.UTF-8, fr_BE.UTF-8, fr_CA.UTF-8, fr_CH.UTF-8, fr_FR.UTF-8, he_IL.UTF-8, hr_HR.UTF-8, hu_HU.UTF-8, hy_AM.UTF-8, is_IS.UTF-8, it_CH.UTF-8, it_IT.UTF-8, ja_JP.UTF-8, kk_KZ.UTF-8, ko_KR.UTF-8, lt_LT.UTF-8, nl_BE.UTF-8, nl_NL.UTF-8, no_NO.UTF-8, pl_PL.UTF-8, pt_BR.UTF-8, pt_PT.UTF-8, ro_RO.UTF-8, ru_RU.UTF-8, sk_SK.UTF-8, sl_SI.UTF-8, sr_YU.UTF-8, sv_SE.UTF-8, tr_TR.UTF-8, uk_UA.UTF-8, zh_CN.UTF-8, zh_HK.UTF-8, zh_TW.UTF-8
2023-02-02 12:50:30:  0: PYTHON: Traceback (most recent call last):

@kalisp
Copy link
Member Author

kalisp commented Feb 2, 2023

Previous error was fixe by setting environment in System Settings:

'LC_ALL'='en_US.UTF-8'
'LANG'='en_US.UTF-8'

Not sure if is not only case of our test machine.

@kalisp kalisp marked this pull request as ready for review February 2, 2023 12:33
@kalisp kalisp requested a review from 64qam February 2, 2023 13:18
@antirotor
Copy link
Member

Previous error was fixe by setting environment in System Settings:

'LC_ALL'='en_US.UTF-8'
'LANG'='en_US.UTF-8'

Not sure if is not only case of our test machine.

I guess this is related to how Python is build using pyenv

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have not tested it, but these changes looks good

clipboarch escapes whitespace with \ on MacOS, so for safety clean it here. Hopefully nobody starts folder name with space on Windows.
@antirotor
Copy link
Member

Now it's even better! :)

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp kalisp assigned 64qam and unassigned kalisp Feb 8, 2023
@64qam 64qam assigned kalisp and unassigned 64qam and kalisp Feb 9, 2023
@kalisp kalisp merged commit 7afbd4b into develop Feb 9, 2023
@kalisp kalisp deleted the bugfix/OP-4513_Deadline-on-MacOS branch February 9, 2023 16:20
@ynbot ynbot added this to the next-patch milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants