Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Houdini shelf tools fixes #4428

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Fix Houdini shelf tools.

Description

Use label as mandatory key instead of name. Changed how shelves are created. If the script is empty it is gracefully skipping it instead of crashing.

Testing notes:

  1. Shelves creation should work

PR is replacement of stale PR #4062

@ynbot
Copy link
Contributor

ynbot commented Feb 3, 2023

Task linked: OP-4355 Houdini: Shelves Tools code broken

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 3, 2023
@iLLiCiTiT iLLiCiTiT added type: bug Something isn't working host: Houdini labels Feb 3, 2023
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@iLLiCiTiT iLLiCiTiT merged commit 0b7ca43 into develop Feb 3, 2023
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-4355_Houdini-Shelves-Tools-code-broken branch February 3, 2023 17:11
@github-actions github-actions bot added this to the next-patch milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants