Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Ignore decode error of stdout/stderr in run_subprocess #4446

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Ignore decode errors and replace invalid character (byte) with escaped byte character.

Description

Calling of run_subprocess may cause crashes if output contains some unicode character which (for example Polish name of encoder handler).

Testing notes:

Issue was discovered by a client so testing notes are related to the case.

  1. Open TrayPublisher
  2. Select family (e.g. Render)
  3. Drop video from client to both (source and reveiw) input fields
  4. Publish
  5. Publishing should went smoothly without issues in ExtractReview plugin

@ynbot
Copy link
Contributor

ynbot commented Feb 9, 2023

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Feb 9, 2023
@64qam
Copy link
Member

64qam commented Feb 10, 2023

Now it crashes on Extract burnins.
publish-report-230210-10-14.txt

Copy link
Member

@Minkiu Minkiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should do de decoding on the args and kwargs of the subprocess?

@iLLiCiTiT
Copy link
Member Author

Now it crashes on Extract burnins.

Should be fixed

Maybe it should do de decoding on the args and kwargs of the subprocess?

It's not issue with args but with output from process.

@64qam
Copy link
Member

64qam commented Feb 10, 2023

still crashing on burnins
publish-report.txt

@iLLiCiTiT
Copy link
Member Author

still crashing on burnins

Forgot tu push one commit

@iLLiCiTiT iLLiCiTiT merged commit f1b5c1f into develop Feb 10, 2023
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-4928_Issue-with-extract-review-on-Web-Publisher-for-specific-MP4s branch February 10, 2023 11:07
@ynbot ynbot added this to the next-patch milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants