Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Arnold Scene Source overhaul - OP-4865 #4449

Merged
merged 25 commits into from Feb 14, 2023
Merged

Maya: Arnold Scene Source overhaul - OP-4865 #4449

merged 25 commits into from Feb 14, 2023

Conversation

tokejepsen
Copy link
Member

@tokejepsen tokejepsen commented Feb 10, 2023 •
edited

Brief description

General overhaul of the Arnold Scene Source (ASS) workflow.

Description

This originally was to support static files (non-sequencial) ASS publishing, but digging deeper whole workflow needed an update to get ready for further issues. During this overhaul the following changes were made:

  • Generalized Arnold Standin workflow to a single loader.
  • Support multiple nodes as proxies.
  • Support proxies for pointcache family.
  • Generalized approach to proxies as resources, so they can be the same file format as the original.

This workflow should allow further expansion to utilize operators and eventually USD.

Discussion

By supporting proxies for the pointcache family, we can also get rid of the specialized proxyAbc workflow. What do we think of that?
We could also implement/support proxy workflows when it comes to animation and rig, although not sure how much that is used outside of big studios.

Testing notes:

  1. Create and publish Arnold Scene Source or Pointcache instance.
  2. Load and render.
  3. Repeat with proxy workflow to see proxy in viewport and original at render time.

@tokejepsen tokejepsen self-assigned this Feb 10, 2023
@ynbot
Copy link
Contributor

ynbot commented Feb 10, 2023

Task linked: OP-4865 static ass file option

@tokejepsen tokejepsen mentioned this pull request Feb 10, 2023
Closed
@tokejepsen tokejepsen marked this pull request as draft February 10, 2023 09:17
@tokejepsen tokejepsen removed the request for review from antirotor February 10, 2023 09:52
@tokejepsen tokejepsen marked this pull request as ready for review February 10, 2023 10:01
Minkiu
Minkiu reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@Minkiu Minkiu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the changes themselves, and I would be keen in adding more Docstrings, even if they seem redundant.

Overall code looks good ✔️

openpype/hosts/maya/plugins/load/load_arnold_standin.py Show resolved Hide resolved
openpype/hosts/maya/plugins/load/load_arnold_standin.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/load/load_arnold_standin.py Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/collect_arnold_scene_source.py Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/collect_pointcache.py Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_pointcache.py Show resolved Hide resolved
openpype/hosts/maya/plugins/load/load_arnold_standin.py Show resolved Hide resolved
@moonyuet
Copy link
Member

I have tested loader and extractor, so far so good. Apart from the question about the second extraction in the extractor, I think it looks ok but it somehow breaks another loader due to the adjustment
image

This is something I saw when I run reference .ass standin with proxy
image

image

@tokejepsen
Copy link
Member Author

tokejepsen commented Feb 10, 2023 •
edited

This is something I saw when I run reference .ass standin with proxy

@moonyuet Not sure how you get that Loader since I've removing it with this commit?
9733b07

@moonyuet
Copy link
Member

I have tested loader and extractor, so far so good. Apart from the question about the second extraction in the extractor, I think it looks ok but it somehow breaks another loader due to the adjustment image

This is something I saw when I run reference .ass standin with proxy image

image

This is something I saw when I run reference .ass standin with proxy

@moonyuet Not sure how you get that Loader since I've removing it with this commit? 9733b07

Sorry, maybe I mixed with other forks. my bad! Let me test again!

@moonyuet
Copy link
Member

I have tested it again, the loader works fine. Sorry for the inconvenience!
image

The ass will be published successfully. Not sure if the ass with "_proxy" needed to be published. If yes, the ass with "_proxy" is not there yet.
image

@tokejepsen
Copy link
Member Author

The ass will be published successfully. Not sure if the ass with "_proxy" needed to be published. If yes, the ass with "_proxy" is not there yet.

@moonyuet the proxy version goes into the resources folder atm. Did you not get it publish and loaded?

antirotor
antirotor approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine, just little style comment to accept or dismiss :)

openpype/hosts/maya/plugins/load/load_arnold_standin.py Outdated Show resolved Hide resolved
@tokejepsen @antirotor
Update openpype/hosts/maya/plugins/load/load_arnold_standin.py
6bdbdd4 
Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
@antirotor antirotor merged commit d06a77d into ynput:develop Feb 14, 2023
@ynbot ynbot added this to the next-patch milestone Feb 14, 2023
@tokejepsen tokejepsen deleted the enhancement/OP-4865_static-ass-file-option branch February 14, 2023 15:42
@tokejepsen tokejepsen mentioned this pull request Feb 14, 2023
Merged
@tokejepsen tokejepsen mentioned this pull request Mar 30, 2023
Merged
@tokejepsen tokejepsen mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minkiu Minkiu Minkiu approved these changes

@antirotor antirotor antirotor approved these changes

@moonyuet moonyuet moonyuet approved these changes

Assignees

@tokejepsen tokejepsen

Labels
host: Maya
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tokejepsen @ynbot @moonyuet @Minkiu @antirotor