Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher: Fix compatibility of QAction in Publisher #4474

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Publisher: Fix compatibility of QAction in Publisher #4474

merged 1 commit into from
Feb 16, 2023
+12 −8

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Fix QAction for older version of Qt bindings where QAction requires a parent on initialization.

Description

This bug was discovered in Nuke 11. Fixed by creating QAction when QMenu is already available and can be used as parent.

Testing notes:

  1. Open Publisher in Nuke 11
  2. Should not crash

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Feb 16, 2023
@antirotor
Copy link
Member

Not so easy to test because of #4475 🤣

antirotor
antirotor approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@iLLiCiTiT iLLiCiTiT merged commit 14d78ae into develop Feb 16, 2023
@iLLiCiTiT iLLiCiTiT deleted the bugfix/publisher_qaction_compatibility branch February 16, 2023 11:34
@ynbot ynbot added this to the next-patch milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antirotor antirotor antirotor approved these changes

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iLLiCiTiT @antirotor @m-u-r-p-h-y @ynbot