Maya: Camera focal length visible in review - OP-3278 #4531

tokejepsen · 2023-02-26T10:25:36Z

Brief description

Camera focal length visible in review.

Description

Support camera focal length in review; static and dynamic.

Resolves #3220

Testing Notes

Change one of the project_settings/global/publish/ExtractBurnin/profiles/0/burnins fields to use {focalLength:.2f} or {focalLength:.0f} or {focalLength}.
Create a camera in Maya with animated focal length.
Create a review and publish.
Validate focal length is present on the burnins on the review.

ynbot · 2023-02-26T10:25:39Z

Task linked: OP-3278 Maya: Camera focal length visible in review

openpype/hosts/maya/plugins/publish/collect_review.py

BigRoy · 2023-03-03T09:48:46Z

How does this code actually work to retrieve the dynamic focal length? :) Where does it end up collecting the values per frame?

tokejepsen · 2023-03-08T09:06:47Z

How does this code actually work to retrieve the dynamic focal length? :) Where does it end up collecting the values per frame?

It doesn't🙂 This is still a draft PR so should be disregarded for reviewing.

openpype/plugins/publish/extract_burnin.py

openpype/scripts/otio_burnin.py

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…com/tokejepsen/pype into feature/OP-3278_camera-focal-length

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…com/tokejepsen/pype into feature/OP-3278_camera-focal-length

openpype/scripts/otio_burnin.py

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

website/docs/pype2/admin_presets_plugins.md

LiborBatek

All works as expected. When focal length animated it correctly shows and updates in burins.

openpype/lib/execute.py

tokejepsen · 2023-03-29T08:18:38Z

@LiborBatek guessing you are happy with this PR? If so could you approve?

@BigRoy @moonyuet you happy with this?

openpype/scripts/otio_burnin.py

BigRoy · 2023-03-29T08:54:34Z

So this PR works perfectly for me in ✅ Maya 2023 but I'm having the issues in ⚠️ Maya 2020 reported by @gabormarinov on discord here which are unrelated to this PR.

I animated focal length in sync with my frame range to ensure it was exactly sync per frame in the resulting burnin - all was good on that front! 👍

Regarding debugging the Maya 2020 issue:

This is what is shown in the Pyblish UI as error message: Cannot apply options Invalid flag ''

These are options being passed to capture.capture:

Using preset:
{
    "camera": "|camera1|cameraShape1", 
    "camera_options": {
        "depthOfField": false, 
        "displayFieldChart": false, 
        "displayFilmGate": false, 
        "displayFilmOrigin": false, 
        "displayFilmPivot": false, 
        "displayGateMask": false, 
        "displayResolution": false, 
        "displaySafeAction": false, 
        "displaySafeTitle": false, 
        "overscan": 1.0
    }, 
    "compression": "jpg", 
    "display_options": {
        "background": [
            0.49019607843137253, 
            0.49019607843137253, 
            0.49019607843137253
        ], 
        "backgroundBottom": [
            0.49019607843137253, 
            0.49019607843137253, 
            0.49019607843137253
        ], 
        "backgroundTop": [
            0.49019607843137253, 
            0.49019607843137253, 
            0.49019607843137253
        ], 
        "displayGradient": true
    }, 
    "end_frame": 1011.0, 
    "filename": "c:\\users\\roy\\appdata\\local\\temp\\pyblish_tmp_xpx6s9\\reviewMain", 
    "format": "image", 
    "height": 1080, 
    "off_screen": true, 
    "overwrite": true, 
    "quality": 95, 
    "sound": null, 
    "start_frame": 991.0, 
    "viewer": false, 
    "viewport2_options": {
        "enableTextureMaxRes": true, 
        "hwFogAlpha": 0, 
        "hwFogColorB": 1.0, 
        "hwFogColorG": 1.0, 
        "hwFogColorR": 1.0, 
        "hwFogDensity": 0.0, 
        "hwFogEnd": 100, 
        "hwFogFalloff": 0, 
        "hwFogStart": 0, 
        "lineAAEnable": true, 
        "motionBlurEnable": false, 
        "motionBlurSampleCount": 8, 
        "motionBlurShutterOpenFraction": 0.2, 
        "multiSampleCount": 8, 
        "multiSampleEnable": true, 
        "renderDepthOfField": true, 
        "ssaoAmount": 1, 
        "ssaoEnable": false, 
        "ssaoFilterRadius": 16, 
        "ssaoRadius": 16, 
        "ssaoSamples": 16, 
        "textureMaxResMode": 1, 
        "textureMaxResolution": 1024
    }, 
    "viewport_options": {
        "backfaceCulling": false, 
        "cameras": false, 
        "clipGhosts": false, 
        "controlVertices": false, 
        "deformers": false, 
        "dimensions": false, 
        "displayLights": "default", 
        "displayTextures": true, 
        "dynamicConstraints": false, 
        "dynamics": false, 
        "fluids": false, 
        "fogging": false, 
        "follicles": false, 
        "gpuCacheDisplayFilter": false, 
        "greasePencils": false, 
        "grid": false, 
        "hairSystems": true, 
        "handles": false, 
        "headsUpDisplay": false, 
        "hulls": false, 
        "ikHandles": false, 
        "imagePlane": true, 
        "jointXray": false, 
        "joints": false, 
        "lights": false, 
        "locators": false, 
        "manipulators": false, 
        "motionTrails": false, 
        "nCloths": false, 
        "nParticles": false, 
        "nRigids": false, 
        "nurbsCurves": false, 
        "nurbsSurfaces": false, 
        "particleInstancers": false, 
        "pivots": false, 
        "planes": false, 
        "pluginShapes": false, 
        "polymeshes": true, 
        "rendererName": "vp2Renderer", 
        "shadows": true, 
        "strokes": false, 
        "subdivSurfaces": false, 
        "textures": false, 
        "twoSidedLighting": true, 
        "useDefaultMaterial": false, 
        "wireframeOnShaded": false, 
        "xray": false
    }, 
    "width": 1920
}

And it appears to error on the viewport options with the modelEditor command on line 748 of capture.py. But when running this in Maya 2020:

import capture

viewport_options = {
    "backfaceCulling": False, 
    "cameras": False, 
    "clipGhosts": False, 
    "controlVertices": False, 
    "deformers": False, 
    "dimensions": False, 
    "displayLights": "default", 
    "displayTextures": True, 
    "dynamicConstraints": False, 
    "dynamics": False, 
    "fluids": False, 
    "fogging": False, 
    "follicles": False, 
    "gpuCacheDisplayFilter": False, 
    "greasePencils": False, 
    "grid": False, 
    "hairSystems": True, 
    "handles": False, 
    "headsUpDisplay": False, 
    "hulls": False, 
    "ikHandles": False, 
    "imagePlane": True, 
    "jointXray": False, 
    "joints": False, 
    "lights": False, 
    "locators": False, 
    "manipulators": False, 
    "motionTrails": False, 
    "nCloths": False, 
    "nParticles": False, 
    "nRigids": False, 
    "nurbsCurves": False, 
    "nurbsSurfaces": False, 
    "particleInstancers": False, 
    "pivots": False, 
    "planes": False, 
    "pluginShapes": False, 
    "polymeshes": True, 
    "rendererName": "vp2Renderer", 
    "shadows": True, 
    "strokes": False, 
    "subdivSurfaces": False, 
    "textures": False, 
    "twoSidedLighting": True, 
    "useDefaultMaterial": False, 
    "wireframeOnShaded": False, 
    "xray": False

}

with capture._applied_viewport_options(viewport_options, "modelPanel1"):
    pass

I get no errors. Which seems weird since it should trigger the same logic.

This does trigger the error however:

import capture
import json

data = r"""
{
    "camera": "|camera1|cameraShape1", 
    "camera_options": {
        "depthOfField": false, 
        "displayFieldChart": false, 
        "displayFilmGate": false, 
        "displayFilmOrigin": false, 
        "displayFilmPivot": false, 
        "displayGateMask": false, 
        "displayResolution": false, 
        "displaySafeAction": false, 
        "displaySafeTitle": false, 
        "overscan": 1.0
    }, 
    "compression": "jpg", 
    "display_options": {
        "background": [
            0.49019607843137253, 
            0.49019607843137253, 
            0.49019607843137253
        ], 
        "backgroundBottom": [
            0.49019607843137253, 
            0.49019607843137253, 
            0.49019607843137253
        ], 
        "backgroundTop": [
            0.49019607843137253, 
            0.49019607843137253, 
            0.49019607843137253
        ], 
        "displayGradient": true
    }, 
    "end_frame": 1011.0, 
    "filename": "c:\\users\\roy\\appdata\\local\\temp\\pyblish_tmp_xpx6s9\\reviewMain", 
    "format": "image", 
    "height": 1080, 
    "off_screen": true, 
    "overwrite": true, 
    "quality": 95, 
    "sound": null, 
    "start_frame": 991.0, 
    "viewer": false, 
    "viewport2_options": {
        "enableTextureMaxRes": true, 
        "hwFogAlpha": 0, 
        "hwFogColorB": 1.0, 
        "hwFogColorG": 1.0, 
        "hwFogColorR": 1.0, 
        "hwFogDensity": 0.0, 
        "hwFogEnd": 100, 
        "hwFogFalloff": 0, 
        "hwFogStart": 0, 
        "lineAAEnable": true, 
        "motionBlurEnable": false, 
        "motionBlurSampleCount": 8, 
        "motionBlurShutterOpenFraction": 0.2, 
        "multiSampleCount": 8, 
        "multiSampleEnable": true, 
        "renderDepthOfField": true, 
        "ssaoAmount": 1, 
        "ssaoEnable": false, 
        "ssaoFilterRadius": 16, 
        "ssaoRadius": 16, 
        "ssaoSamples": 16, 
        "textureMaxResMode": 1, 
        "textureMaxResolution": 1024
    }, 
    "viewport_options": {
        "backfaceCulling": false, 
        "cameras": false, 
        "clipGhosts": false, 
        "controlVertices": false, 
        "deformers": false, 
        "dimensions": false, 
        "displayLights": "default", 
        "displayTextures": true, 
        "dynamicConstraints": false, 
        "dynamics": false, 
        "fluids": false, 
        "fogging": false, 
        "follicles": false, 
        "gpuCacheDisplayFilter": false, 
        "greasePencils": false, 
        "grid": false, 
        "hairSystems": true, 
        "handles": false, 
        "headsUpDisplay": false, 
        "hulls": false, 
        "ikHandles": false, 
        "imagePlane": true, 
        "jointXray": false, 
        "joints": false, 
        "lights": false, 
        "locators": false, 
        "manipulators": false, 
        "motionTrails": false, 
        "nCloths": false, 
        "nParticles": false, 
        "nRigids": false, 
        "nurbsCurves": false, 
        "nurbsSurfaces": false, 
        "particleInstancers": false, 
        "pivots": false, 
        "planes": false, 
        "pluginShapes": false, 
        "polymeshes": true, 
        "rendererName": "vp2Renderer", 
        "shadows": true, 
        "strokes": false, 
        "subdivSurfaces": false, 
        "textures": false, 
        "twoSidedLighting": true, 
        "useDefaultMaterial": false, 
        "wireframeOnShaded": false, 
        "xray": false
    }, 
    "width": 1920
}
"""

preset = json.loads(data)
capture.capture(**preset)

Which errors with:

# ERROR - Cannot apply options Invalid flag ''
# Error: pyblish.ExtractPlayblast : Cannot apply options Invalid flag '' #

This also shows a different bug, with capture.py that it actually overrides its default logger too as soon as you ever pass any log argument to capture.capture due it storing it in a global. That's why it's also showing the pyblish.ExtractPlayblast prefix in my log

tokejepsen · 2023-03-29T09:02:33Z

Maya 2020 reported by @gabormarinov on discord here which are unrelated to this PR.

@BigRoy we'll need to tackle this in a separate PR or issue.
If you are otherwise happy with this PR, could you approve?

moonyuet

It works in my side too. can you please merge the latest develop to this branch?

Static implementation.

00f2e16

tokejepsen added host: Maya type: feature Larger, user affecting changes and completely new things labels Feb 26, 2023

tokejepsen self-assigned this Feb 26, 2023

moonyuet reviewed Mar 3, 2023

View reviewed changes

openpype/hosts/maya/plugins/publish/collect_review.py Outdated Show resolved Hide resolved

tokejepsen added 2 commits March 21, 2023 09:07

Merge branch 'develop' into feature/OP-3278_camera-focal-length

92c8562

Initial working version

e9eb09e

BigRoy reviewed Mar 22, 2023

View reviewed changes

openpype/plugins/publish/extract_burnin.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 22, 2023

View reviewed changes

openpype/scripts/otio_burnin.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 22, 2023

View reviewed changes

openpype/scripts/otio_burnin.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 22, 2023

View reviewed changes

openpype/scripts/otio_burnin.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 22, 2023

View reviewed changes

openpype/scripts/otio_burnin.py Outdated Show resolved Hide resolved

tokejepsen and others added 12 commits March 22, 2023 14:58

Update openpype/scripts/otio_burnin.py

9eadc11

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Store burnin data as dictionary directly.

22dac59

Merge branch 'feature/OP-3278_camera-focal-length' of https://github.…

78b7c8d

…com/tokejepsen/pype into feature/OP-3278_camera-focal-length

Clean up prints

f0bdc76

Update openpype/scripts/otio_burnin.py

266992f

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Merge branch 'feature/OP-3278_camera-focal-length' of https://github.…

20a0028

…com/tokejepsen/pype into feature/OP-3278_camera-focal-length

Update type error message

4f334a1

Get FPS properly

4f0aafe

Hound

a364a82

Code cosmetics

84817a7

Clean up temporary files and support float truncating

7ff781f

Docs

833e48a

tokejepsen marked this pull request as ready for review March 22, 2023 16:44

tokejepsen requested a review from LiborBatek March 22, 2023 16:44

tokejepsen assigned LiborBatek Mar 22, 2023

tokejepsen assigned LiborBatek and unassigned tokejepsen and LiborBatek Mar 22, 2023

BigRoy reviewed Mar 27, 2023

View reviewed changes

openpype/scripts/otio_burnin.py Outdated Show resolved Hide resolved

tokejepsen and others added 3 commits March 27, 2023 10:07

Update openpype/scripts/otio_burnin.py

52511c1

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Finish method description

28a4f09

Change method name

eaca4f5

BigRoy reviewed Mar 27, 2023

View reviewed changes

website/docs/pype2/admin_presets_plugins.md Show resolved Hide resolved

Add maya specific burnin profile.

85196b6

LiborBatek previously approved these changes Mar 28, 2023

View reviewed changes

tokejepsen commented Mar 29, 2023

View reviewed changes

openpype/lib/execute.py Outdated Show resolved Hide resolved

Update openpype/lib/execute.py

7264ce3

tokejepsen dismissed LiborBatek’s stale review via 7264ce3 March 29, 2023 08:17

tokejepsen assigned moonyuet and unassigned LiborBatek Mar 29, 2023

moonyuet reviewed Mar 29, 2023

View reviewed changes

openpype/scripts/otio_burnin.py Show resolved Hide resolved

BigRoy approved these changes Mar 29, 2023

View reviewed changes

tokejepsen mentioned this pull request Mar 29, 2023

Maya: Extract Playblast in 2020. #4730

Closed

moonyuet approved these changes Mar 29, 2023

View reviewed changes

Merge branch 'develop' into feature/OP-3278_camera-focal-length

b7f6589

mkolar approved these changes Mar 29, 2023

View reviewed changes

mkolar merged commit b17ff80 into ynput:develop Mar 29, 2023

ynbot added this to the next-patch milestone Mar 29, 2023

tokejepsen deleted the feature/OP-3278_camera-focal-length branch March 29, 2023 09:38

BigRoy mentioned this pull request Mar 29, 2023

Houdini: Implement review family with opengl node #3839

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maya: Camera focal length visible in review - OP-3278 #4531

Maya: Camera focal length visible in review - OP-3278 #4531

tokejepsen commented Feb 26, 2023 •

edited

ynbot commented Feb 26, 2023

BigRoy commented Mar 3, 2023

tokejepsen commented Mar 8, 2023

LiborBatek left a comment •

edited

tokejepsen commented Mar 29, 2023

BigRoy commented Mar 29, 2023 •

edited

tokejepsen commented Mar 29, 2023

moonyuet left a comment

Maya: Camera focal length visible in review - OP-3278 #4531

Maya: Camera focal length visible in review - OP-3278 #4531

Conversation

tokejepsen commented Feb 26, 2023 • edited

Brief description

Description

Testing Notes

ynbot commented Feb 26, 2023

BigRoy commented Mar 3, 2023

tokejepsen commented Mar 8, 2023

LiborBatek left a comment • edited

Choose a reason for hiding this comment

tokejepsen commented Mar 29, 2023

BigRoy commented Mar 29, 2023 • edited

tokejepsen commented Mar 29, 2023

moonyuet left a comment

Choose a reason for hiding this comment

tokejepsen commented Feb 26, 2023 •

edited

LiborBatek left a comment •

edited

BigRoy commented Mar 29, 2023 •

edited