General: We should keep current subset version when we switch only the representation type

[kaamaurice]

Changelog Description

When we switch only the representation type of subsets, we should not get the representation from the last version of the subset.

Testing notes:

1. Load a subset with several representation(any host)
2. Set version that is not the last existing version.
3. Switch the subset representation using the scene inventory.
4. Version should not change to the latest.

Additional suggestion

We could implement a version combobox selection to the switch dialog.

[tokejepsen]

Tested in Nuke and it still updates to latest version.

@kaamaurice which hosts did you test this in?

[tokejepsen]

@kaamaurice any reason for closing this?

[kaamaurice]

@tokejepsen Sorry, I have a very weird issue with branche names how start with enhancement/
VSCode add an upper case and I can't push commits after publishing the branch.

[kaamaurice]

Tested with Blender

[tokejepsen]

Tested in Maya 2023 with model and it still updates to latest version.

[BigRoy]

I gave this a go and on my first try it didn't work and I wanted to respond like @tokejepsen mentioned:

Tested in Maya 2023 with model and it still updates to latest version.

I had the exact same problem. However this only occurs if you select a single container (or multiple containers that are exactly the same asset+subset+representation) in the scene inventory because then by default the switch asset box "preselects" the asset, subset and representation and thus logic fails.

If you remove the asset + subset selection then it works for that case too. But admittedly that's very confusing as you can see from both @tokejepsen and my first test run.
For cases where you select multiple containers those values are not preselected it works right out of the box. ✅

I'd actually like to argue that maybe even for the 'select single container' case we shouldn't be preselecting and then this logic automatically works. It's extra confusing because it has a preselection and lists "No changes*" which technically is correct, but if you empty the field and re-enter exactly the value that it was then suddenly it lists as changes.

OR if we want to keep the automatic selection for switch asset on a single container then we should at least fix how we detect whether the option was explicitly defined by the artist - which apparently IS possible because *No changes is shown below it too - maybe we can just detect the "No changes" in a way.

[BigRoy]

Any chance we could see movement int his PR again @tokejepsen @kaamaurice ?

[kaamaurice]

Hi ! I'm back ! So sorry for the delay, we had so much work with our blender pipe at Normaal Animation Studio.
I now able to test within Maya, I should be more consistent for the future. Thanks for the reviews.

[iLLiCiTiT]

Can someone test this with hero versions?

[kaamaurice]

Can someone test this with hero versions?

Traceback (most recent call last):
  File "D:\Tools\OpenPype\openpype\tools\sceneinventory\switch_dialog.py", line 1181, in _on_accept
    self._trigger_switch()
  File "D:\Tools\OpenPype\openpype\tools\sceneinventory\switch_dialog.py", line 1257, in _trigger_switch
    container_version_name = container_version["name"]
KeyError: 'name'

Oups I have an issue, sorry, I fix this !

[kaamaurice]

Works now as expected with hero version.

[mkolar]

This is looking good, however whatever I do I can't checkout the branch. Actually i can't even find in when I add you remote @kaamaurice .

[kaamaurice]

@mkolar Thanks for the review. I had some weird issue with VS code when I create and publish a new branch how start with enhancement/ ! I get a E uppercase in my remote branch but my local branch stile named without uppercase.

So checkout Enhancement/general_switch_dialog_keep_current_version should work

[Tilix4]

Hi @mkolar, did you have time to review since the last changes?

[iLLiCiTiT]

Changes make sense. LGTM

outdated