Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Fix Collect Render for V-Ray, Redshift and Renderman for missing colorspace #4650

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 17, 2023

Changelog Description

Fix Collect Render not working for Redshift, V-Ray and Renderman due to missing colorspace argument to RenderProduct dataclass.

Additional info

Not entirely sure if this is the correct colorspace solution for all renderers. But at least this should hotfix the collecting not working at all.

Testing notes:

Test submitting renders with:

  • Maya + Redshift
  • Maya + V-Ray
  • Maya + Renderman

- Not entirely sure this is the correct colorspace solution for all renderers. But at least this hotfixes the collecting.
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested the function by myself but the code looks okay for me

@LiborBatek LiborBatek self-requested a review March 21, 2023 08:00
@LiborBatek
Copy link
Member

LiborBatek commented Mar 22, 2023

First test with Vray passed ok, not any issues found.
image

Regarding the testing of Redshift and Renderman I cant get working license :( ...will do when having those working...

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 29, 2023

What's the ETA on merging this? Without this submitting renders from maya with Redshift, V-Ray and Renderman will likely not work.

@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Mar 29, 2023
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Dont have access to Redshift or Renderman to test.

@moonyuet
Copy link
Member

moonyuet commented Apr 2, 2023

I have tested Redshift and it passes the collect render layers as expected.
image
I also tested with Renderman, it also passes the collect render layers as expected
image
Will test the submission later.

@moonyuet
Copy link
Member

moonyuet commented Apr 2, 2023

Tested with submission, Both redshift and renderman published without any error in the publisher
image
image
I think it's ready to merge

@mkolar mkolar merged commit e670ac7 into ynput:develop Apr 3, 2023
@ynbot ynbot added this to the next-patch milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect Render Layer errors out when the renderer is redshift
7 participants