Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Lib code cleanup #5003

Merged
merged 7 commits into from
May 24, 2023
Merged

General: Lib code cleanup #5003

merged 7 commits into from
May 24, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Small cleanup in lib files in openpype.

Additional info

These are small changes I've made in last few weeks locally during other feature/bugfix development. Implemented Python 2 compatible function is_func_signature_supported to check if function can accept arguments without calling the function. Class WeakMethod can be imported from python_2_comp in any python version. Updated docstrings in publish lib.

Testing notes:

  1. Read the changes in docstrings
  2. Event system should work in python 2 and python 3

@ynbot ynbot added size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality labels May 22, 2023
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it doesn't break anything afaik.

@iLLiCiTiT iLLiCiTiT merged commit 248336b into develop May 24, 2023
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/lib_code_cleanup branch May 24, 2023 08:51
@ynbot ynbot added this to the next-patch milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants