General: Show user who created the workfile on the details pane of workfile manager #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiaserra
changed the title
ynbot
added
size/XS
fabiaserra
commented
Jun 2, 2023
|
Can't test outside of windows at the moment, but the code is looking good and it behaves correctly in windows. Meaning nothing changes. |
|
Awesome, thank you @mkolar for testing! |
iLLiCiTiT
reviewed
Jun 5, 2023
iLLiCiTiT
reviewed
Jun 5, 2023
iLLiCiTiT
reviewed
Jun 5, 2023
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
reviewed
Jun 5, 2023
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
approved these changes
Jun 5, 2023
I can confirm it still works with the current changes on my Linux box. Re: mac I don't have OP set up there but I could confirm that |
|
Thank you @fabiaserra merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
New PR for #5087, which was closed after merging
next-minorbranch and then realizing we don't need to target it as it was decided it's not required to support windows. More info on that PR discussion.Small addition to add name of the
userwho created the workfile on the details pane of the workfile manager:Testing notes:
Userentry showing who created that file