Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Maya / Nuke remove publish gui filters from settings #5570

Merged
merged 16 commits into from Dec 21, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Sep 5, 2023

Changelog Description

  • Remove Publish GUI Filters from Nuke settings
  • Remove Publish GUI Filters from Maya settings

Additional info

Note that it seems like both TVPaint and Hiero also have the Publish GUI Filter settings currently - I am not sure if those use the new publisher already and whether it's worth also removing those in this PR or not.

I'm not sure how AYON settings work with its versioning - so let me know if the changes/commits seem like the right way.

Testing notes:

  1. Ensure Nuke + Maya settings + publishing still work (in both AYON and OpenPype)

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Maya host: Nuke labels Sep 5, 2023
@BigRoy BigRoy marked this pull request as ready for review October 2, 2023 11:18
@LiborBatek
Copy link
Member

@BigRoy I would like to test this PR but Im not so sure for what I should be looking. Could you add more info on that pls?
Thx

@BigRoy
Copy link
Collaborator Author

BigRoy commented Oct 4, 2023

I'm not sure either - as far as I can tell these were publisher presets for the old publisher that'd set the Optional states of certain plugins according to the preset. The new publisher doesn't have this concept since it stores and remembers tweaked settings and thus there's much less need for these presets.

@iLLiCiTiT @antirotor any idea whether it makes sense to remove these settings?

Also note the comment I made about TV Paint in the PR description under Additional Info

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Oct 4, 2023

I'm not sure either - as far as I can tell these were publisher presets for the old publisher that'd set the Optional states of certain plugins according to the preset. The new publisher doesn't have this concept since it stores and remembers tweaked settings and thus there's much less need for these presets.

Exactly, this cannot be tested, because settings that were removed, were not used.

Also note the comment I made about TV Paint in the PR description under Additional Info

Yes, we should remove the settings for them too. I'll leave it up to you if you want to add it to this PR.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Oct 4, 2023

Yes, we should remove the settings for them too. I'll leave it up to you if you want to add it to this PR.

@iLLiCiTiT only for those that do not use the old publisher anymore, correct? (I believe Hiero still does)

@iLLiCiTiT
Copy link
Member

only for those that do not use the old publisher anymore, correct? (I believe Hiero still does)

Yes, from the remaining it is only TVPaint.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Oct 7, 2023

Ready to check again @iLLiCiTiT

# Conflicts:
#	server_addon/nuke/server/version.py
@iLLiCiTiT iLLiCiTiT merged commit e46e762 into ynput:develop Dec 21, 2023
11 checks passed
@ynbot ynbot added this to the next-patch milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution host: Maya host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants