Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: change label in the render settings to be more readable #5713

Closed

Conversation

antirotor
Copy link
Member

Changelog Description

Fixing labels in Maya Render Settings where the labels could be misleading about how to enter values.

@antirotor antirotor added type: enhancement Enhancements to existing functionality host: Maya labels Oct 6, 2023
@antirotor antirotor self-assigned this Oct 6, 2023
@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Oct 6, 2023
@antirotor antirotor changed the title ♻️ change label to be more readable Maya: change label in the render settings to be more readable Oct 6, 2023
@@ -145,7 +145,7 @@
},
{
"type": "label",
"label": "Add additional options - put attribute and value, like <code>defaultArnoldRenderOptions.AASamples</code> = <code>4</code>"
"label": "Add additional options - put attribute and value, like <code>defaultArnoldRenderOptions.AASamples</code> for attribute and to next field value <code>4</code>"
Copy link
Collaborator

@BigRoy BigRoy Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't feel that much clearer to me.

Suggested change
"label": "Add additional options - put attribute and value, like <code>defaultArnoldRenderOptions.AASamples</code> for attribute and to next field value <code>4</code>"
"label": "Add additional required attribute values - set the attribute and value, like <code>defaultArnoldRenderOptions.AASamples</code> with the node name with attribute left and the required value to the right <code>4</code>"

Not sure if the UI is left right like that, but that reads clearer to me at least.

Also, are these labels also in AYON settings? If so, might need updating there too?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The hinting text is kind of convoluted/unclear.

I would go with just

Add additional options - put attribute_name and value, example: defaultArnoldRenderOptions.AASamples 4

@tokejepsen
Copy link
Member

Closing this in favour of #6134

@tokejepsen tokejepsen closed this Jan 16, 2024
@ynbot ynbot added this to the next-patch milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants