-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Houdini: Allow using template keys in Houdini shelves manager #5727
Enhancement: Houdini: Allow using template keys in Houdini shelves manager #5727
Conversation
2 similar comments
okay, here's what happens when creating a new shelf:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MustafaJafar it works now after your guidance, thank you!
Would you use template keys to test this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about updating the algorithm of shelves manager as follows ?
|
This is similar to the way how the shelves in maya. so I agree that we should do what you suggested |
I added an issue to track it, Thanks! |
d3c6532
to
246d01e
Compare
@BigRoy Could you have a look? I'll appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test the code - but the changes make sense. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works and code looks good, even though setting the shelves up isn't very intuitive process.
Changelog Description
Allow using Template keys in Houdini shelves manager.
Testing notes: