Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Houdini: Allow using template keys in Houdini shelves manager #5727

Merged

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Allow using Template keys in Houdini shelves manager.

image

Testing notes:

  1. add shelves or tools wile using template keys
  2. check in houdini for their existence

@MustafaJafar MustafaJafar added type: enhancement Enhancements to existing functionality host: Houdini labels Oct 9, 2023
@ynbot
Copy link
Contributor

ynbot commented Oct 9, 2023

2 similar comments
@ynbot
Copy link
Contributor

ynbot commented Oct 9, 2023

@ynbot
Copy link
Contributor

ynbot commented Oct 9, 2023

@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Oct 9, 2023
@MustafaJafar MustafaJafar linked an issue Oct 9, 2023 that may be closed by this pull request
2 tasks
@moonyuet
Copy link
Member

moonyuet commented Oct 9, 2023

I have tested in Houdini. But for some reason the shelf doesn't show up on the shelf menu.
image

@MustafaJafar
Copy link
Contributor Author

okay, here's what happens when creating a new shelf:

  1. use shelf set path if exists and ignore everything, you should find it when clicking the + sign

Note that shelves manager ignores the set name in this case (which is a bug here)

  1. create a shelf with the given shelf name if not exists and shelf set name and add the given tools

Note that it will save these data in the default shelf, so you may need to clean it.

your configuration should be split into two like this:
image

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaJafar it works now after your guidance, thank you!
image

@MustafaJafar
Copy link
Contributor Author

Would you use template keys to test this PR ?
I can tell from your screen shot that I forgot to allow using template keys with icon paths!

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Looks good without the shelf_set_source_path

But I included the optional path shelf_set_source_path, the shelf menu doesn't show up in the list of shelves.
I need to create the shelf manually and named the shelf so that the script would be loaded in the shelf.

@MustafaJafar
Copy link
Contributor Author

But I included the optional path shelf_set_source_path, the shelf menu doesn't show up in the list of shelves.
I need to create the shelf manually and named the shelf so that the script would be loaded in the shelf.

what about updating the algorithm of shelves manager as follows ?

  1. if shelf_set_source_path only exists, then add it as a shelf in Houdini
  2. if tools_list are provided without shelf_set_source_path, then create shelf with the given name in the default shelf.
  3. if tools_list and shelf_set_source_path are provided, then create a shelf with the given path and add these tools to it. (however, I believe TDs can just create a shelf regularly then rely on the first case specified above.)

@moonyuet
Copy link
Member

But I included the optional path shelf_set_source_path, the shelf menu doesn't show up in the list of shelves.
I need to create the shelf manually and named the shelf so that the script would be loaded in the shelf.

what about updating the algorithm of shelves manager as follows ?

  1. if shelf_set_source_path only exists, then add it as a shelf in Houdini
  2. if tools_list are provided without shelf_set_source_path, then create shelf with the given name in the default shelf.
  3. if tools_list and shelf_set_source_path are provided, then create a shelf with the given path and add these tools to it. (however, I believe TDs can just create a shelf regularly then rely on the first case specified above.)

This is similar to the way how the shelves in maya. so I agree that we should do what you suggested

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Oct 10, 2023

This is similar to the way how the shelves in maya. so I agree that we should do what you suggested

I added an issue to track it, Thanks!
#5738

@MustafaJafar MustafaJafar force-pushed the enhancement/OP-6710_Houdini-Shelves-Manager-use-templates branch from d3c6532 to 246d01e Compare October 18, 2023 14:34
@MustafaJafar
Copy link
Contributor Author

@BigRoy Could you have a look? I'll appreciate it.

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test the code - but the changes make sense. Looks good to me.

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and code looks good, even though setting the shelves up isn't very intuitive process.

@antirotor antirotor merged commit e8e1109 into develop Oct 19, 2023
1 check passed
@ynbot ynbot added this to the next-patch milestone Oct 19, 2023
@antirotor antirotor deleted the enhancement/OP-6710_Houdini-Shelves-Manager-use-templates branch November 29, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Houdini Shelves Manager: pathes are not resolved if template keys are used
5 participants