Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader tool: Refactor loader tool (for AYON) #5729

Merged
merged 69 commits into from
Oct 11, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 9, 2023

Changelog Description

Refactored loader tool to new tool. Separated backend and frontend logic. Refactored logic is AYON-centric and is used only in AYON mode, so it does not affect OpenPype. The tool is also replacing library loader.

Additional info

There were made smaller changes in the tool UI. Versions comboboxes are visible all the time, the tool can be used as both loader and library loader tools. The tool does not contain logic related to site sync - that will be added in future PRs.

Screenshot

image

Known issues/TODOs

  • Missing docstring (everywhere).
  • Loader plugins do not recognize if are shown in "library loader" mode or "loader" mode.
  • Missing option to change product group (Ctrl + G shortcut).
  • Not used in tray action yet.
  • Find more suitable size of the window.
  • ... report anything you'll hit

Testing notes:

Basic tests

  1. Create openpype package
  2. Update openpype package to server
  3. Set the package to production bundle
  4. Run AYON-launcher
  5. Run a host of your choise (should have loader tool)
  6. Try to use the loader tool
  7. It should work as expected
    Possible usecases:
  • load should work
  • crashed load should show message box
  • load options should show UI which is propagating the values to load
  • refresh should refresh
  • grouping should show groups
  • thumbnails should be visible
  • all kind of filtering should filter

@LiborBatek
Copy link
Member

Gives me some error during launch of Loader inside of maya host app

Using existing QApplication..
# Error: AttributeError: file C:\Users\Libor\AppData\Local\Ynput\AYON\addons\openpype_3.17.2-nightly.2\openpype\tools\utils\host_tools.py line 126: 'LoaderWindow' object has no attribute 'refresh'

@LiborBatek
Copy link
Member

When trying yo load an asset:
image

@LiborBatek
Copy link
Member

When triggering Reference Abc or Reference Ma in both cases the Loader will load both repre...no matter which one was selected...should be just the one selected.
image

@LiborBatek
Copy link
Member

Seems like its trying to load all repre available on asset even when selecting just particular type ...in this case abc fbx max etc...
image

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 10, 2023

By the way, is this lacking the Dependency tab?

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Oct 10, 2023

By the way, is this lacking the Dependency tab?

Oh yes, forgot about dependency tab. Yes, it's not there, and probably won't be in this PR, unless you have some serious reason to have it?

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 10, 2023

And I know it's not up to this PR to add new features - but I would 100% love there to be a Versions tabs that is basically a list widget showing the publish dates, status, author and comments of all versions for the selected subset.

Currently there's just no UI that can show you the publish dates of the last few versions and their respective comments.

Here's a Prism equivalent on the right hand side:

Not super pretty but it shows the data I'm referring to.
Also, this shows workfiles - not published outputs; but it contains the same data basically

I thought we had an existing issue to track that as a feature request - but I can't find it.

@LiborBatek
Copy link
Member

When thumbnail having transparency it should show solid bg color and probably not checkered bg

image

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 10, 2023

When thumbnail having transparency it should show solid bg color and probably not checkered bg

image

Or at the very least have a less harsh checkboard pattern, lighter gray and white can help:

How come the checkerboard in your screenshot appears to be 'red tinted' - do you have some screen tools to dim your screens (like "night light" or alike?)

@LiborBatek
Copy link
Member

LiborBatek commented Oct 10, 2023

How come the checkerboard in your screenshot appears to be 'red tinted' - do you have some screen tools to dim your screens (like "night light" or alike?)

Nope. Strange...

I think it already had been handled well (transparency with thumbnails) in Legacy OP as seen here...I really like it comped onto bg color btw, looks neat!

2023-10-10.15-12-26.mp4

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 10, 2023

Red tint

Quickly threw that image into Fusion. Only the light squares aren't exact gray tint:
image

But even the red there makes a very subtle difference - so whether I'm actually able to see a 'red tint' might be just me being crazy.

I think it already had been handled well (transparency with thumbnails) in Legacy OP as seen here...I really like it comped onto bg color btw, looks neat!

I guess the thumbnail on solid background does look nice enough, yes.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did multiple tests in different scenarios and all seem working normally aka well.

@iLLiCiTiT iLLiCiTiT merged commit 0498a40 into develop Oct 11, 2023
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-5034_Loader-using-AYON-calls branch October 11, 2023 16:16
@ynbot ynbot added this to the next-patch milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR changes 2500+ lines, ignoring general files type: feature Larger, user affecting changes and completely new things
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants