Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Render Settings cleanup remove global RENDER_ATTRS #5801

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Maya: Render Settings cleanup remove global RENDER_ATTRS #5801

merged 1 commit into from
Nov 15, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Oct 20, 2023

Changelog Description

Remove global lib.RENDER_ATTRS and implement a RenderSettings.get_padding_attr(renderer) method instead.

Additional info

Allows more re-use of the functionality and has a simpler entry point to use it.

Testing notes:

  1. Submitting renders should still work

@BigRoy
Remove global RENDER_ATTRS, refactor to a `RenderSettings.get_paddi…
7caaea4 
…ng_attr` method

- Partial cleanup extracted from ynput#3880
@BigRoy BigRoy added host: Maya type: refactor Structural changes not affecting functionality community contribution labels Oct 20, 2023
@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality labels Oct 20, 2023
LiborBatek
LiborBatek approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems working fine. I was able to submit to DL normally without any issues.
image

kalisp
kalisp approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@kalisp kalisp merged commit 5d10f7f into ynput:develop Nov 15, 2023
10 checks passed
@ynbot ynbot added this to the next-patch milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees
No one assigned
Labels
community contribution host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality type: refactor Structural changes not affecting functionality
Projects
PR reviewing
Archived in project
Milestone
3.17.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BigRoy @kalisp @LiborBatek @ynbot