Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: updated colorspace settings #5906

Merged

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 13, 2023

Changelog Description

Updating nuke colorspace settings into more convenient way with usage of ocio config roles rather then particular colorspace names. This way we should not have troubles to switch between linear Rec709 or ACES configs without any additional settings changes.

Testing notes:

  1. Create new project with some nuke task and keep colormanagement in global to be disabled
  2. Open nuke in the project task and see all is working as expected - no colorspace issues.
  3. Go to global colorspace management switch and enable it.
  4. Open Nuke again and check if there is no colormanagement issue.

@ynbot
Copy link
Contributor

ynbot commented Nov 13, 2023

Task linked: OP-7197 nuke: default colorspace settings

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality host: Nuke labels Nov 13, 2023
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without global ocio enabled and local ocio enabled

image

With global ocio enabled
image

With nuke ocio enabled
image

When opening the files again, the read nodes no longer error out
image

@rontown
Copy link

rontown commented Nov 13, 2023

Looks as though you are still missing the custom ocio config selection. I made a PR for this a couple of days ago. Might be worth adding that to this PR?

#5900

@jakubjezek001 jakubjezek001 merged commit 4519736 into develop Nov 16, 2023
19 checks passed
@ynbot ynbot added this to the next-patch milestone Nov 16, 2023
@jakubjezek001 jakubjezek001 deleted the enhancement/OP-7197_nuke-default-colorspace-settings branch November 16, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants