Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: bug fix the playblast without textures #5942

Merged
merged 58 commits into from Jan 3, 2024
Merged

Maya: bug fix the playblast without textures #5942

merged 58 commits into from Jan 3, 2024
+404 −296

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Nov 22, 2023 •
edited

Changelog Description

Bug fix the texture not being displayed when users enable texture placement in the OP/AYON setting

Additional info

It causes additional time for playblasting if users have tons of UDIMs texture.

Testing notes:

  1. Go to project_settings/maya/publish/ExtractPlayblast/ to add profiles
  2. Go to project_settings/maya/publish/ExtractPlayblast/profiles/0/capture_preset/Viewport Options/loadTextures
  3. Enable this also
  4. Launch Maya
  5. Create Review while creating some other instances from other families
  6. Publish.

@ynbot
Copy link
Contributor

ynbot commented Nov 22, 2023

Task linked: OP-7281 Maya: Review - playblast renders without textures

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Maya labels Nov 22, 2023
@moonyuet moonyuet marked this pull request as ready for review November 22, 2023 12:13
@moonyuet moonyuet requested a review from BigRoy November 23, 2023 09:31
LiborBatek
LiborBatek approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OP does create Review with textures being loaded and also forcing regenerate all UV tiles previews.

image

Small note:

during publishing of the review there some warnings of failures, not sure if relevant but at least something to consider, even tho this PR being functional...
image

BigRoy
BigRoy reviewed Nov 23, 2023
View reviewed changes
openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_playblast.py Outdated Show resolved Hide resolved
@moonyuet moonyuet requested a review from BigRoy November 24, 2023 08:59
@moonyuet moonyuet requested a review from BigRoy November 24, 2023 10:15
BigRoy
BigRoy suggested changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change capture.py dependency, pop the reloadTextures key instead.

Other than that the code looks good.

openpype/vendor/python/common/capture.py Outdated Show resolved Hide resolved
openpype/settings/lib.py Outdated Show resolved Hide resolved
@moonyuet moonyuet requested a review from BigRoy November 27, 2023 10:09
BigRoy
BigRoy reviewed Dec 21, 2023
View reviewed changes
openpype/hosts/maya/api/exitstack.py Outdated Show resolved Hide resolved
openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
@moonyuet moonyuet requested a review from BigRoy December 21, 2023 10:33
@moonyuet moonyuet requested a review from BigRoy December 21, 2023 16:35
BigRoy
BigRoy approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not do a test run, sorry! But the code changes do look like decent cleanup and refactoring. Good stuff! Please do some thorough testing of reviews and thumbnails, whether the presets settings still propagate as expected, whether resolutions are still ok, etc.

Once that's done, then 🚀

@BigRoy BigRoy mentioned this pull request Dec 22, 2023
Merged
@moonyuet moonyuet mentioned this pull request Dec 22, 2023
Merged
@moonyuet moonyuet requested a review from Minkiu January 2, 2024 11:15
LiborBatek
LiborBatek requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another test go in maya 2023 and maya 2024 but without any success

still
image

Also enclosing full JSON report when publishing...

publish-report-240102-14-17.json.txt

@moonyuet
Copy link
Member Author

moonyuet commented Jan 2, 2024

@LiborBatek I have updated the testing notes and codes regarding to your suggestion in discord. Can you please test it? Thanks!

Minkiu
Minkiu approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@Minkiu Minkiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but code looks good.

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_thumbnail.py Outdated Show resolved Hide resolved
antirotor
antirotor approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it in Maya 2024 and it works, code looks reasonable too, so 👍🏻

@moonyuet
Copy link
Member Author

moonyuet commented Jan 3, 2024

@LiborBatek can you possibly test again? This ticket needs your approval so that it can be merged, Thanks!

LiborBatek
LiborBatek approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems working fine! Now
image

@moonyuet moonyuet merged commit 5e48d24 into develop Jan 3, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/OP-7281_Maya-Review---playblast-renders-without-textures branch January 3, 2024 16:03
@ynbot ynbot added this to the next-patch milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minkiu Minkiu Minkiu approved these changes

@BigRoy BigRoy BigRoy approved these changes

@antirotor antirotor antirotor approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@BigRoy BigRoy

@antirotor antirotor

@LiborBatek LiborBatek

Labels
host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested target: AYON type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.3
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@moonyuet @ynbot @BigRoy @Minkiu @antirotor @LiborBatek @m-u-r-p-h-y @mkolar @MustafaJafar