-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: dump_databases flag #5955
Merged
kalisp
merged 6 commits into
ynput:develop
from
tokejepsen:feature/testing_dump_databases_flag
Dec 6, 2023
Merged
Testing: dump_databases flag #5955
kalisp
merged 6 commits into
ynput:develop
from
tokejepsen:feature/testing_dump_databases_flag
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
Denotes a PR changes 0-99 lines, ignoring general files
type: feature
Larger, user affecting changes and completely new things
labels
Nov 26, 2023
tokejepsen
commented
Nov 26, 2023
Putting this on hold while I work on the json export, cause this flag should determine the output format. |
Ready for review again. |
kalisp
approved these changes
Dec 6, 2023
kalisp
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size/XS
Denotes a PR changes 0-99 lines, ignoring general files
sponsored
Client endorsed or requested
type: feature
Larger, user affecting changes and completely new things
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This introduces a
dump_databases
flag which makes it convenient to output the resulting database of a successful test run. The flag supports two formats;bson
andjson
.Due to outputting to the test data folder, when dumping the databases, the test data folder will persist.
Split from #5644
Testing notes:
NOTE: I have not tested all integrations cause I dont have them locally.