Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AYON: Fix thumbnail integration #5970

Merged
merged 1 commit into from
Nov 29, 2023
Merged

AYON: Fix thumbnail integration #5970

merged 1 commit into from
Nov 29, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Thumbnail integration could cause crash of server if thumbnail id was changed for the same entity id multiple times. Modified the code to avoid that issue.

Additional info

This was discovered as bug on server backend and will be handled by failing the operations. So this fix is also required for future backend fix.

Testing notes:

  1. Use host of your choice.
  2. Make sure you have at least 2 instances with same folder that will integrate thumbnail.
  3. Publish them.
  4. Integrate thumbnail should not fail.

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Nov 29, 2023
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected.

published 4 instances of render to a single shot.

all published fast and without issue. all thumbnails are visible in Ayon

image

@iLLiCiTiT iLLiCiTiT merged commit c9701ac into develop Nov 29, 2023
15 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/ayon-integrate-thumbnail-issue branch November 29, 2023 17:07
@ynbot ynbot added this to the next-patch milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.17.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iLLiCiTiT @m-u-r-p-h-y @ynbot