-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: Release Maya/Deadline job from pending when testing. #5988
Testing: Release Maya/Deadline job from pending when testing. #5988
Conversation
Split from #5644 |
This test was created as simple model and workfile publish, without Deadline rendering. Cleaned up render elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in submit*
absolute necessary? They are ugly af.
I don't see to much performance gains vs polluting code with this check. (I cry anytime I need to put one of these somewhere.)
@kalisp not sure what removing the render instance, has to do with this PR?
I would be up for leaving the changes in submit publish plugin, as it could introduce issues down the line if spawning multiple workers on a machine. |
…g_deadline_maya_pending # Conflicts: # tests/integration/hosts/maya/test_publish_in_maya/expected/test_project/test_asset/work/test_task/test_project_test_asset_test_task_v001.ma # tests/integration/hosts/maya/test_publish_in_maya/expected/test_project/test_asset/work/test_task/test_project_test_asset_test_task_v002.ma # tests/integration/hosts/maya/test_publish_in_maya/input/workfile/test_project_test_asset_test_task_v001.ma
It seems to work and doesn't break anything else. |
Changelog Description
When testing we wont put the Deadline jobs into pending with dependencies, so the worker can start as soon as possible.
Testing notes:
Verify the jobs on Deadline are not put into pending initially.