Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Release Maya/Deadline job from pending when testing. #5988

Merged

Conversation

tokejepsen
Copy link
Member

Changelog Description

When testing we wont put the Deadline jobs into pending with dependencies, so the worker can start as soon as possible.

Testing notes:

openpype_console runtests C:\Users\tokejepsen\OpenPype\tests\integration\hosts\maya\test_deadline_publish_in_maya.py --mongo_url "mongodb://localhost:2707/"

Verify the jobs on Deadline are not put into pending initially.

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Dec 1, 2023
@tokejepsen tokejepsen self-assigned this Dec 1, 2023
@ynbot ynbot added host: Maya module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Dec 1, 2023
@tokejepsen
Copy link
Member Author

Split from #5644

@tokejepsen tokejepsen assigned kalisp and unassigned tokejepsen Dec 5, 2023
This test was created as simple model and workfile publish, without Deadline rendering. Cleaned up render elements.
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in submit* absolute necessary? They are ugly af.

I don't see to much performance gains vs polluting code with this check. (I cry anytime I need to put one of these somewhere.)

@kalisp kalisp assigned tokejepsen and unassigned kalisp Dec 7, 2023
@mkolar mkolar removed the sponsored Client endorsed or requested label Dec 7, 2023
@tokejepsen
Copy link
Member Author

tokejepsen commented Dec 11, 2023

@kalisp not sure what removing the render instance, has to do with this PR?
It has introduced a merge conflict as well.

Are the changes in submit* absolute necessary? They are ugly af.

I would be up for leaving the changes in submit publish plugin, as it could introduce issues down the line if spawning multiple workers on a machine.

…g_deadline_maya_pending

# Conflicts:
#	tests/integration/hosts/maya/test_publish_in_maya/expected/test_project/test_asset/work/test_task/test_project_test_asset_test_task_v001.ma
#	tests/integration/hosts/maya/test_publish_in_maya/expected/test_project/test_asset/work/test_task/test_project_test_asset_test_task_v002.ma
#	tests/integration/hosts/maya/test_publish_in_maya/input/workfile/test_project_test_asset_test_task_v001.ma
@kalisp
Copy link
Member

kalisp commented Jan 3, 2024

It seems to work and doesn't break anything else.

@kalisp kalisp merged commit e4e6503 into ynput:develop Jan 3, 2024
3 checks passed
@ynbot ynbot added this to the next-patch milestone Jan 3, 2024
@tokejepsen tokejepsen deleted the enhancement/testing_deadline_maya_pending branch January 3, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya module: Deadline AWS Deadline related features size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants