Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Account and ignore free image planes. #5993

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

tokejepsen
Copy link
Member

Changelog Description

Free image planes do not have the -> path separator, so we need to account for that.

Testing notes:

  1. Create camera in Maya.
  2. Create free image plane.
  3. Assign camera to image plane.
  4. Publish.

@tokejepsen tokejepsen self-assigned this Dec 4, 2023
@tokejepsen tokejepsen changed the title Maya: Account and ignore for free image planes. Maya: Account and ignore free image planes. Dec 4, 2023
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Maya labels Dec 4, 2023
@BigRoy
Copy link
Collaborator

BigRoy commented Dec 4, 2023

Funny - I just fixed this today.. and more!

It also captures images planes that aren't actually connected currently (e.g. those that are set to "see through camera" or whatever but aren't input connections anymore - so I fixed that up as well by explicitly only looking for image planes that are connected as inputs to the imagePlane attribute.

My code is here

@tokejepsen
Copy link
Member Author

@BigRoy if you setup a PR, I think dont mind closing this one.

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for me. Tested in AYON. Looks good.
image
loaded by referencing the ma file. Works fine.
image

@kalisp
Copy link
Member

kalisp commented Jan 5, 2024

Applied changes from BigRoy.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did create free imagePlane and defined a camera1 as a looking through camera

image

Not sure what does mean step 3 exactly assign a camera to imagePlane in testing steps tho...

Publish went without any issues and fine. Again quite vague what to publish (Camera??)

However as we strip everything during camera product publish not sure whats the point here?

@BigRoy @tokejepsen Should I somehow connect the imagePlane then (node editor??)

Also only matchMove and mayaScene product can publish Camera with imagePlanes no?

@kalisp kalisp merged commit a6cc0b5 into ynput:develop Jan 16, 2024
3 checks passed
@ynbot ynbot added this to the next-patch milestone Jan 16, 2024
@tokejepsen tokejepsen deleted the bugfix/maya_camera_image_planes branch January 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants