Refactor colorspace handling in CollectColorspace plugin #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the code to use more descriptive variable names - Added a helper method `_colorspace_name_by_type` to retrieve the colorspace name based on its type - Updated logging statements for better clarity and readability Fix validation error in ValidateColorspace plugin - Added a check to ensure that the OCIO config contains at least one colorspace - If no colorspaces are found, an error is raised with appropriate messages and descriptions - Updated logging statement to include a pretty-printed representation of the config's colorspaces
ynbot
added
type: bug
jakubjezek001
requested review from
64qam,
antirotor,
iLLiCiTiT and
LiborBatek
BigRoy
reviewed
Dec 8, 2023
openpype/hosts/traypublisher/plugins/publish/validate_colorspace.py
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Dec 8, 2023
openpype/hosts/traypublisher/plugins/publish/collect_explicit_colorspace.py
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Dec 8, 2023
openpype/hosts/traypublisher/plugins/publish/validate_colorspace.py
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Dec 8, 2023
openpype/hosts/traypublisher/plugins/publish/collect_explicit_colorspace.py
Outdated
Show resolved
Hide resolved
…ce.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…ce.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
BigRoy
reviewed
Dec 19, 2023
openpype/hosts/traypublisher/plugins/publish/collect_explicit_colorspace.py
Show resolved
Hide resolved
64qam
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Traypublisher is now capable set available colorspaces or roles to publishing images sequence or video. This is fix of new implementation where we allowed to use roles in the enumerator selector.
Additional info
_colorspace_name_by_typeto retrieve the colorspace name based on its typeFix validation error in ValidateColorspace plugin
Testing notes:
Open Traypublisher at project where colormanagement is activated to ACES
Create product
plateorrenderand drop any sequence or video to appropriate fields.On right set any from the options > try roles or colrospace
hit Validate and all should go trough as expected.