Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion: Project/User option for output format (create_saver) #6045

Merged
merged 8 commits into from Dec 14, 2023

Conversation

Sponge96
Copy link
Contributor

Changelog Description

Adds "Output Image Format" option which can be set via project settings and overwritten by users in "Create" menu. This replaces the current behaviour of being hardcoded to "exr". Replacing the need for people to manually edit the saver path if they require a different extension.

Additional info

I've removed some potential bloat saver["OutputFormat"] = file_format. In my testing Fusion is able to infer this information based on the file extension (Fusion17 and 18).

Testing notes:

  1. Launch OP Project settings
  2. Tweak the new option "Output Image Format" (see screenshot below)
image
  1. Launch project in Fusion
  2. Open "Create" menu
  3. Check that "Output Image Format" matches your new default
  4. Create and validate that it has respected your format (also check that it infers the correct "Output Format" etc)

@ynbot ynbot added size/S Denotes a PR changes 100-499 lines, ignoring general files host: Fusion labels Dec 12, 2023
@kalisp kalisp self-assigned this Dec 14, 2023
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for predefined set of outputs.

(It might be enhanced by dynamically adding additional extensions, if it would be required.)

@kalisp kalisp merged commit 9711900 into ynput:develop Dec 14, 2023
3 checks passed
@ynbot ynbot added this to the next-patch milestone Dec 14, 2023
@Sponge96 Sponge96 deleted the fusion_create_saver_update branch December 14, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution host: Fusion size/S Denotes a PR changes 100-499 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants