New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fusion: Project/User option for output format (create_saver) #6045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/S
Denotes a PR changes 100-499 lines, ignoring general files
host: Fusion
labels
Dec 12, 2023
BigRoy
reviewed
Dec 12, 2023
openpype/settings/entities/schemas/projects_schema/schema_project_fusion.json
Show resolved
Hide resolved
BigRoy
reviewed
Dec 12, 2023
BigRoy
reviewed
Dec 12, 2023
kalisp
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for predefined set of outputs.
(It might be enhanced by dynamically adding additional extensions, if it would be required.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community contribution
host: Fusion
size/S
Denotes a PR changes 100-499 lines, ignoring general files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Adds "Output Image Format" option which can be set via project settings and overwritten by users in "Create" menu. This replaces the current behaviour of being hardcoded to "exr". Replacing the need for people to manually edit the saver path if they require a different extension.
Additional info
I've removed some potential bloat
saver["OutputFormat"] = file_format
. In my testing Fusion is able to infer this information based on the file extension (Fusion17 and 18).Testing notes: