Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender: Workfile instance update fix #6048

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Make sure workfile instance has always available 'instance_node' in transient data.

Additional info

The instance node was available only if something had changed or the instance was created.

Testing notes:

  1. Launch blender
  2. Open publisher tool
  3. Save and Reset tool
  4. There should not be any issue saving it

@ynbot ynbot added host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working labels Dec 13, 2023
@moonyuet
Copy link
Member

moonyuet commented Jan 3, 2024

I have tested with Blender.
Save and reset works as expected. But I do have a question: Is it normal for the optional extractor always turned off after save while I turned on it (before save)?
You can find the video below as reference.
https://github.com/ynput/OpenPype/assets/64118225/2ba0e727-aff6-4b2f-a46c-c3e1d292afb0

@BigRoy
Copy link
Collaborator

BigRoy commented Jan 3, 2024

I have tested with Blender. Save and reset works as expected. But I do have a question: Is it normal for the optional extractor always turned off after save while I turned on it (before save)? You can find the video below as reference. https://github.com/ynput/OpenPype/assets/64118225/2ba0e727-aff6-4b2f-a46c-c3e1d292afb0

No, that would be a bug. The value should persist.

However since that toggle is not on the workfile instance I believe it has nothing to do with this PR and likely was a bug prior to it?

@iLLiCiTiT iLLiCiTiT merged commit 629b49c into develop Jan 11, 2024
11 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/blender-workfile-create-fix branch January 11, 2024 15:15
@ynbot ynbot added this to the next-patch milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants