Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fusion: fix for single frame rendering #6056

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fusion: fix for single frame rendering #6056

merged 1 commit into from
Dec 18, 2023
+5 −1

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Dec 14, 2023 •
edited
Loading

Changelog Description

Fixes publishes of single frame of render product type.

Additional info

Files must be string not single element array.

Testing notes:

  1. set timeline to single frame
  2. set Frame range source
    image

@kalisp kalisp self-assigned this Dec 14, 2023
@ynbot
Copy link
Contributor

ynbot commented Dec 14, 2023

Task linked: OP-7470 Fusion: new creator plugin single frame saver

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Fusion labels Dec 14, 2023
BigRoy
BigRoy approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have pretty much the same fix on our end here so I suppose this looks good?

@kalisp kalisp assigned jakubjezek001 and unassigned kalisp Dec 14, 2023
@kalisp kalisp marked this pull request as ready for review December 14, 2023 12:04
@Sponge96
Copy link
Contributor

Works great on our end!

jakubjezek001
jakubjezek001 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalisp kalisp merged commit 443d107 into develop Dec 18, 2023
17 of 18 checks passed
@ynbot ynbot added this to the next-patch milestone Dec 18, 2023
@mkolar mkolar deleted the bugfix/OP-7470_Fusion-new-creator-plugin-single-frame-saver branch January 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Fusion size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kalisp @ynbot @Sponge96 @BigRoy @jakubjezek001