Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AYON Chore: Do not use thumbnailSource for thumbnail integration #6063

Merged
merged 1 commit into from Dec 19, 2023
Merged

AYON Chore: Do not use thumbnailSource for thumbnail integration #6063

merged 1 commit into from Dec 19, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 15, 2023 •
edited

Changelog Description

Do not use thumbnailSource for thumbnail integration.

Additional info

The value of "thumbnailSource" is what should be used as source for "thumbnailPath", so it can be .exr, .mp4 etc. all of them are invalid for thumbnail. It looks like it was accidentaly used instead of thumbnailPath and nobody noticed...

OpenPype Note

I found out the logic how to determine what should be used as thumbnail is different in AYON and OpenPype integrator. Looks like the logic in OpenPype is quite old.

Steps to replicate issues

  • Open traypublisher
  • Select render
  • Pass as source file mp4 and use the same mp4 for review
  • Publish
  • Integrate thumbnail will probably crash because mp4 is invalid file for thumbnail

Testing notes:

  1. Thumbnail publishing should work as expected

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Dec 15, 2023
@iLLiCiTiT iLLiCiTiT mentioned this pull request Dec 18, 2023
Merged
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

published mp4 file as render (source + review)

image

@iLLiCiTiT iLLiCiTiT merged commit 4db853e into develop Dec 19, 2023
14 of 15 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/integrate-thumbnail-does-not-use-thumbsource branch December 19, 2023 10:24
@ynbot ynbot added this to the next-patch milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@simonebarbieri simonebarbieri Awaiting requested review from simonebarbieri

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@jakubjezek001 jakubjezek001

Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iLLiCiTiT @m-u-r-p-h-y @mkolar @jakubjezek001 @ynbot