Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Photoshop: fix creation of .mov #6064

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Photoshop: fix creation of .mov #6064

merged 1 commit into from
Dec 18, 2023

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Dec 18, 2023

Changelog Description

Generation of .mov file with 1 frame per published layer was failing.

Testing notes:

  1. set ayon+settings://photoshop/publish/ExtractReview?project=demo_Commercial Make an image sequence instead of flatten image

image

  1. publish workfile with multiple image instances
  2. it shouldn't fail

@kalisp kalisp requested a review from 64qam December 18, 2023 13:10
@ynbot
Copy link
Contributor

ynbot commented Dec 18, 2023

Task linked: OP-7606 ExtractReview fails when creating .mov file

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Photoshop type: bug Something isn't working labels Dec 18, 2023
@kalisp kalisp assigned LiborBatek and unassigned 64qam Dec 18, 2023
@LiborBatek LiborBatek self-requested a review December 18, 2023 14:07
LiborBatek
LiborBatek approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as expected...for 3 image products,

it does produces mov file with 3 frames each representing image instance.

image

@kalisp kalisp merged commit 0252c9e into develop Dec 18, 2023
16 checks passed
@kalisp kalisp deleted the bugfix/OP-7606_ExtractReview-fails-when-creating-mov-file branch December 18, 2023 15:02
@ynbot ynbot added this to the next-patch milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

@64qam 64qam Awaiting requested review from 64qam

Assignees

@LiborBatek LiborBatek

Labels
host: Photoshop size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalisp @ynbot @LiborBatek @64qam