Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python console widget: Save registry fix #6076

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Do not save registry until there is something to save.

Additional info

The addon logic tries to store last save registry even if console is not showed up at all, which may lead to confusing scenarios when None is stored as ideal width and height etc.

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Dec 19, 2023
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tried to open/close console couple of time.

(Btw. it is saving only size to registry, not position, correct?)

@iLLiCiTiT iLLiCiTiT merged commit 64d3961 into develop Dec 20, 2023
15 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/python-console-save-registry-fix branch December 20, 2023 17:34
@ynbot ynbot added this to the next-patch milestone Dec 20, 2023
@iLLiCiTiT
Copy link
Member Author

(Btw. it is saving only size to registry, not position, correct?)

Position is actually potential danger. Changes of resolution, scaling etc. can cause that window would appear out of desktop positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants