-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Apply initial viewport shader for Redshift Proxy after loading #6102
Maya: Apply initial viewport shader for Redshift Proxy after loading #6102
Conversation
Task linked: OP-6655 Maya: redshift proxy viewport shader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, by default a mesh created with cmds.createNode("mesh")
does not have a shader assigned. With this added logic it will now get the lambert1
(or standardSurface1
) assigned depending on which is the configured initial shading group.
Didn't test, but looks good to me.
Changelog Description
When the published redshift proxy is being loaded, the shader of the proxy is missing. This is different from the manual load through creating redshift proxy for files. This PR is to assign the default lambert to the redshift proxy, which replicates the same approach when the user manually loads the proxy with filepath.
Additional info
If there is a way of which we should get attributes of proxy materials in redshift proxy mesh, some conditions can be set up for assigning the shader if it exists in the scene.
Testing notes: