Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher: Fix issue with parenting of widgets #6106

Merged
merged 1 commit into from Jan 11, 2024
Merged

Publisher: Fix issue with parenting of widgets #6106

merged 1 commit into from Jan 11, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Don't use publisher window parent (usually main DCC window) as parent for report widget.

Additional info

This caused issues with parenting. E.g. in older versions of nuke was the publisher empty on re-open.

Testing notes:

  1. Publisher should be possible to open multiple times in Nuke 13 and lower

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working host: Nuke labels Jan 5, 2024
@iLLiCiTiT iLLiCiTiT removed host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 5, 2024
@iLLiCiTiT iLLiCiTiT requested a review from kalisp January 9, 2024 15:02
jakubjezek001
jakubjezek001 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iLLiCiTiT iLLiCiTiT merged commit aba6171 into develop Jan 11, 2024
15 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/publisher-ui-parenting-issue branch January 11, 2024 11:07
@ynbot ynbot added this to the next-patch milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@jakubjezek001 jakubjezek001

Labels
target: AYON target: OpenPype type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iLLiCiTiT @jakubjezek001 @ynbot