Site Sync: small fixes in Loader #6119

kalisp · 2024-01-11T15:01:22Z

Changelog Description

Resolves issue:

local and studio icons were same, they should be different
TypeError: string indices must be integers error when downloading/uploading workfiles

enable Site Sync for your project (must be enabled in Studio settings and Project Settings too!)
set in Local settings active_site to 'local' and remote_site to 'studio`
check Availability icons in Ayon Loader
try do download workfile

Returned item is dictionary of version_id: links, previous loop was looping through [[]].

local and studio have both same provider, local_drive. Both of them should be differentiate by icon though.

openpype/client/server/entity_links.py

openpype/tools/ayon_loader/models/site_sync.py

Icon_def is dictionary with `type` and `path` keys, not directly 'path'. It must be massaged first.

…ix/site_sync_issues_in_loader

openpype/tools/ayon_sceneinventory/models/site_sync.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

kalisp added 2 commits January 11, 2024 13:51

Fix usage of correct values

622668e

Returned item is dictionary of version_id: links, previous loop was looping through [[]].

Fix usage of studio icon

3e0fb62

local and studio have both same provider, local_drive. Both of them should be differentiate by icon though.

kalisp requested a review from LiborBatek January 11, 2024 15:01

kalisp assigned iLLiCiTiT Jan 11, 2024

ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 11, 2024

iLLiCiTiT reviewed Jan 11, 2024

View reviewed changes

openpype/client/server/entity_links.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Jan 11, 2024

View reviewed changes

openpype/tools/ayon_loader/models/site_sync.py Show resolved Hide resolved

kalisp added 2 commits January 11, 2024 17:56

Fix - pull only paths from icon_def

d51b7f3

Icon_def is dictionary with `type` and `path` keys, not directly 'path'. It must be massaged first.

Merge branch 'develop' of https://github.com/ynput/OpenPype into bugf…

0804aa2

…ix/site_sync_issues_in_loader

iLLiCiTiT reviewed Jan 12, 2024

View reviewed changes

openpype/tools/ayon_sceneinventory/models/site_sync.py Outdated Show resolved Hide resolved

kalisp and others added 2 commits January 12, 2024 10:39

Revert back, fixed in different PR

f1f5cce

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Fix looping

1887ffa

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

iLLiCiTiT approved these changes Jan 12, 2024

View reviewed changes

kalisp merged commit 0461540 into develop Jan 12, 2024
3 checks passed

kalisp deleted the bugfix/site_sync_issues_in_loader branch January 12, 2024 09:44

ynbot added this to the next-patch milestone Jan 12, 2024