New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max: Implementation of Validate Render Passes #6138
Conversation
Task linked: OP-7074 Validate Render Passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test in max 2023
with arnold
render and even tho the Validator
works fine for output file path (Im not sure speaking of AOVs names because I kept those at defaults) it errrors out with following error:
DEBUG: Response <RestApiResponse [200]>
Traceback (most recent call last):
File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2401161802_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
runner(*args)
File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5-nightly.3\openpype\hosts\max\plugins\publish\save_scenes_for_cameras.py", line 37, in process
new_output = RenderSettings().get_batch_render_output(camera) # noqa
File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5-nightly.3\openpype\hosts\max\api\lib_rendersettings.py", line 190, in get_batch_render_output
target_layer = rt.batchRenderMgr.GetView(target_layer_no)
RuntimeError: Unknown MAXScript exception raised.
it is more likely unrelated issue to the implementation of validator, I already created a PR to fix this issue: #6163 |
71fa50c
to
410b111
Compare
I have been testing Whats still mystery to me being @moonyuet any insight how it should work or how to setup correctly? |
It's normal case for Arnold not producing beauty as its API limitation doesn't allow to support AOVs temprarily. |
@LiborBatek I have created an issue for multilayering support in the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking that Separate files for AOVs
which took me some time to find (thx @moonyuet ) it works as expected.
My publishing and render being correctly produced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just quickly went throught the code and it looks fine
Changelog Description
This PR is to enhance the current validator of checking the render output before deadline publish. It does the following:
Render Output for Deadline
would be renamed asValidate Render Passes
Additional info
n/a
Testing notes: