Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add addons dir only if exists #6140

Merged
merged 1 commit into from Jan 17, 2024
Merged

Chore: Add addons dir only if exists #6140

merged 1 commit into from Jan 17, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Do not add addons directory path for addons discovery if does not exists.

Additional info

The main reason is that this folder is causing warning log which is confusing for users.

*** WRN: >>> { ModulesLoader }: [  Could not find path when loading OpenPype modules "C:\Users\USER\AppData\Local\Ynput\AYON\addons\openpype_3.18.4-nightly.1\openpype\addons"  ]

Testing notes:

  1. The warning should not appear anymore

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 16, 2024
kalisp
kalisp approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log is gone, I tested some publishing which worked fine, so hopefully it won't break anything.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Jan 17, 2024
@iLLiCiTiT iLLiCiTiT merged commit 8454269 into develop Jan 17, 2024
16 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/add-addons-dir-only-if-exists branch January 17, 2024 13:47
@ynbot ynbot added this to the next-patch milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.18.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iLLiCiTiT @kalisp @ynbot