Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workfile Template Builder: Use correct variable in create placeholder #6141

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Workfile Template Builder: Use correct variable in create placeholder #6141

merged 1 commit into from
Jan 26, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Use correct variable where failed instances are stored for validation.

Additional info

Current implementation was using _failed_representations which was copied from load, but should use _failed_created_publish_instances.

Testing notes:

Not sure how to test. Probably cause an error of create placeholder during workfile template builder.

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 16, 2024
BigRoy
BigRoy approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense. Without this it would be:

Unresolved attribute reference '_failed_representations' for class 'CreatePlaceholderItem'

Didn't test it.

jakubjezek001
jakubjezek001 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works in AY

@iLLiCiTiT iLLiCiTiT merged commit 766622f into develop Jan 26, 2024
16 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/template-builder-use-correct-variable branch January 26, 2024 15:16
@ynbot ynbot added this to the next-patch milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iLLiCiTiT @BigRoy @jakubjezek001 @ynbot