New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiero: Effect Categories - OP-7397 #6143
Hiero: Effect Categories - OP-7397 #6143
Conversation
Task linked: OP-7397 Hiero: separate effect to lut and repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work! Can we also add default values as you were showing in documentation into the variable DEFAULT_PUBLISH_PLUGIN_SETTINGS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it seems like the exported effects json is not correct. In my case it had published the contect like this a01vfxd_sh010_effectPlateP01Look_v001.json
{
"assignTo": "plateP01"
}
Publisher instances are correct
Conclusion:
It is not collecting soft effect nodes and then those are not serialized into json files.
I would maybe argue that we should not have any defaults to maintain backwards compatibility? |
@jakubjezek001 I'm not entirely sure what you meant here, but I've fixed the case where effects are not categorized, in which case we just dump the effects into the "main" effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the suggestion is implemented anyhow, then it is good for merge.
Co-authored-by: Jakub Ježek <jakub@ynput.io>
Changelog Description
This PR introduces
Effect Categories
for the Hiero settings. This allows studios to split effect stacks into meaningful subsets.Testing notes:
Effect Categories
in Hiero addon settings (see documentation).