Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiero: Effect Categories - OP-7397 #6143

Merged

Conversation

tokejepsen
Copy link
Member

Changelog Description

This PR introduces Effect Categories for the Hiero settings. This allows studios to split effect stacks into meaningful subsets.

Testing notes:

  1. Setup Effect Categories in Hiero addon settings (see documentation).
  2. Setup a clip in Hiero with effects corresponding to the settings.
  3. Publish clip and effects.
  4. Load into Nuke and verify the effects are grouped correctly.

@ynbot
Copy link
Contributor

ynbot commented Jan 16, 2024

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/S Denotes a PR changes 100-499 lines, ignoring general files host: Hiero labels Jan 16, 2024
@tokejepsen
Copy link
Member Author

Docs ynput/ayon-documentation#123

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! Can we also add default values as you were showing in documentation into the variable DEFAULT_PUBLISH_PLUGIN_SETTINGS?

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it seems like the exported effects json is not correct. In my case it had published the contect like this a01vfxd_sh010_effectPlateP01Look_v001.json

{
    "assignTo": "plateP01"
}

Timeline effects
image

Publisher instances are correct
image

Conclusion:
It is not collecting soft effect nodes and then those are not serialized into json files.

@tokejepsen
Copy link
Member Author

Can we also add default values as you were showing in documentation into the variable DEFAULT_PUBLISH_PLUGIN_SETTINGS?

I would maybe argue that we should not have any defaults to maintain backwards compatibility?

@tokejepsen
Copy link
Member Author

It is not collecting soft effect nodes and then those are not serialized into json files.

@jakubjezek001 I'm not entirely sure what you meant here, but I've fixed the case where effects are not categorized, in which case we just dump the effects into the "main" effects.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the suggestion is implemented anyhow, then it is good for merge.

Co-authored-by: Jakub Ježek <jakub@ynput.io>
@jakubjezek001 jakubjezek001 merged commit 2245f6c into ynput:develop Jan 23, 2024
1 check passed
@ynbot ynbot added this to the next-patch milestone Jan 23, 2024
@tokejepsen tokejepsen deleted the enhancement/OP-7397_effect_categories branch January 23, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Hiero size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants