Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: Render Workfile Attributes #6146

Conversation

tokejepsen
Copy link
Member

Changelog Description

Workfile Dependency default value can now be controlled from project settings.
Use Published Workfile makes using published workfiles for rendering optional.

Testing notes:

  1. Toggle deadline/publish/NukeSubmitDeadline/workfile_dependency off.
  2. Create Write instance in Nuke and check the Workfile Dependency is off.
  3. Toggle Use Published Workfile and validate the Deadline job is using the work area workfile.

@ynbot
Copy link
Contributor

ynbot commented Jan 17, 2024

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Nuke module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality labels Jan 17, 2024
@tokejepsen
Copy link
Member Author

Docs ynput/ayon-documentation#126

@jakubjezek001
Copy link
Member

looks good, we will also need to bump the version in server_addon\nuke\server\version.py

@tokejepsen
Copy link
Member Author

looks good, we will also need to bump the version in server_addon\nuke\server\version.py

Good point! Done.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenPype settings works as expected but Ayon server is not workfing well. Please check default settings if there are correctly set.

Traceback (most recent call last):
2024-01-18 14:57:56       File "/backend/api/settings/settings.py", line 178, in get_all_settings
2024-01-18 14:57:56         settings = await addon.get_studio_settings(variant)
2024-01-18 14:57:56                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-18 14:57:56       File "/backend/ayon_server/addons/addon.py", line 288, in get_studio_settings
2024-01-18 14:57:56         settings = await self.get_default_settings()
2024-01-18 14:57:56                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-18 14:57:56       File "/addons/deadline/0.1.7/__init__.py", line 17, in get_default_settings
2024-01-18 14:57:56         return settings_model_cls(**DEFAULT_VALUES)
2024-01-18 14:57:56                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-18 14:57:56       File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
2024-01-18 14:57:56     pydantic.error_wrappers.ValidationError: 1 validation error for DeadlineSettings
2024-01-18 14:57:56     publish -> NukeSubmitDeadline -> use_published_workfile
2024-01-18 14:57:56       field required (type=value_error.missing)
2024-01-18 14:57:56     

@jakubjezek001
Copy link
Member

jakubjezek001 commented Jan 18, 2024

looks good, we will also need to bump the version in server_addon\nuke\server\version.py

Good point! Done.

Sorry for my mistake in the path, but it should be increased in deadline server addon not nuke.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Jan 23, 2024
@jakubjezek001 jakubjezek001 merged commit 06c0bf3 into ynput:develop Jan 24, 2024
1 check passed
@ynbot ynbot added this to the next-patch milestone Jan 24, 2024
@tokejepsen tokejepsen deleted the enhancement/OP-7940_render_workfile_attributes branch January 25, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke module: Deadline AWS Deadline related features size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants