Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Remove duplicate plugin #6157

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

tokejepsen
Copy link
Member

Changelog Description

The two plugins below are doing the same work, so we can remove the one focused solely on lookdev.

https://github.com/ynput/OpenPype/blob/develop/openpype/hosts/maya/plugins/publish/validate_look_members_unique.py
https://github.com/ynput/OpenPype/blob/develop/openpype/hosts/maya/plugins/publish/validate_node_ids_unique.py

Testing notes:

  1. Setup lookdev in Maya duplicate cbids, by duplicating a mesh after cbid has been created.
  2. Publish and validate should pick up the non-unique cbids.

@ynbot ynbot added host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 24, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me but having tested the code.
And the two validators do check exactly the same unique ids in the instance, we can just combine into one instead.

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you are correct - I did not test it however.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Validator works as expected and kicks in when duplicate ID objects found in the asset.

image

@tokejepsen tokejepsen assigned antirotor and unassigned LiborBatek Jan 25, 2024
@moonyuet moonyuet merged commit 6ddc8d9 into ynput:develop Jan 25, 2024
1 check passed
@ynbot ynbot added this to the next-patch milestone Jan 25, 2024
@tokejepsen tokejepsen deleted the chore/maya_remove_duplicate_plugin branch January 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants