Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AYON: Remove kitsu addon #6172

Merged
merged 1 commit into from
Jan 26, 2024
Merged

AYON: Remove kitsu addon #6172

merged 1 commit into from
Jan 26, 2024
+0 −132

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Removed kitsu addon from server addons because already has own repository.

@iLLiCiTiT iLLiCiTiT requested a review from kalisp January 26, 2024 11:56
@ynbot ynbot added the size/S Denotes a PR changes 100-499 lines, ignoring general files label Jan 26, 2024
@ynbot ynbot added type: enhancement Enhancements to existing functionality module: Kitsu Kitsu integration labels Jan 26, 2024
BigRoy
BigRoy approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the ayon-kitsu repo is the active state for Kitsu in AYON then removing it here makes total sense 👍

Didn't test it though.

kalisp
kalisp approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings in separate addon seems to be missing defaults as they are here, but thats problem of separate addon and of this repo.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Jan 26, 2024
@iLLiCiTiT iLLiCiTiT merged commit 8651775 into develop Jan 26, 2024
22 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/remove-kitsu-ayon-settings branch January 26, 2024 16:55
@ynbot ynbot added this to the next-patch milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@kalisp kalisp kalisp approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
module: Kitsu Kitsu integration size/S Denotes a PR changes 100-499 lines, ignoring general files target: AYON type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.18.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iLLiCiTiT @BigRoy @kalisp @ynbot